| Message ID | 20200522102448.30209-1-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v3,1/3] regulator: max14577: Add proper dt-compatible strings | expand |
On Fri, May 22, 2020 at 12:24:46PM +0200, Marek Szyprowski wrote: > Add device tree compatible strings and create proper modalias structures > to let this driver load automatically if compiled as module, because > max14577 MFD driver creates MFD cells with such compatible strings. Same issue as before, you're putting the current Linux model into DT without adding any additional description of the hardware.
diff --git a/drivers/regulator/max14577-regulator.c b/drivers/regulator/max14577-regulator.c index 07a150c9bbf2..4c9ae52b9e87 100644 --- a/drivers/regulator/max14577-regulator.c +++ b/drivers/regulator/max14577-regulator.c @@ -238,10 +238,20 @@ static const struct platform_device_id max14577_regulator_id[] = { }; MODULE_DEVICE_TABLE(platform, max14577_regulator_id); +static const struct of_device_id of_max14577_regulator_dt_match[] = { + { .compatible = "maxim,max14577-regulator", + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, }, + { .compatible = "maxim,max77836-regulator", + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, }, + { }, +}; +MODULE_DEVICE_TABLE(of, of_max14577_regulator_dt_match); + static struct platform_driver max14577_regulator_driver = { .driver = { - .name = "max14577-regulator", - }, + .name = "max14577-regulator", + .of_match_table = of_max14577_regulator_dt_match, + }, .probe = max14577_regulator_probe, .id_table = max14577_regulator_id, };
Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- v3: - sorted of_max14577_regulator_dt_match v2: - added .of_match_table pointer --- drivers/regulator/max14577-regulator.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)