| Message ID | 20200522102448.30209-3-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v3,1/3] regulator: max14577: Add proper dt-compatible strings | expand |
Hi, On Fri, May 22, 2020 at 12:24:48PM +0200, Marek Szyprowski wrote: > Add device tree compatible strings and create proper modalias structures > to let this driver load automatically if compiled as module, because > max14577 MFD driver creates MFD cells with such compatible strings. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- I saw some discussion for patch 1, but still queued this considering the compatible string is already documented in the DT bindings and at least one of them is already being used in DT files. TL;DR: Thanks, queued. -- Sebastian > v3: > - sorted of_max14577_charger_dt_match > v2: > - added .of_match_table pointer > --- > drivers/power/supply/max14577_charger.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/power/supply/max14577_charger.c b/drivers/power/supply/max14577_charger.c > index 8a59feac6468..96f4cd1941b2 100644 > --- a/drivers/power/supply/max14577_charger.c > +++ b/drivers/power/supply/max14577_charger.c > @@ -623,9 +623,19 @@ static const struct platform_device_id max14577_charger_id[] = { > }; > MODULE_DEVICE_TABLE(platform, max14577_charger_id); > > +static const struct of_device_id of_max14577_charger_dt_match[] = { > + { .compatible = "maxim,max14577-charger", > + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, }, > + { .compatible = "maxim,max77836-charger", > + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, of_max14577_charger_dt_match); > + > static struct platform_driver max14577_charger_driver = { > .driver = { > .name = "max14577-charger", > + .of_match_table = of_max14577_charger_dt_match, > }, > .probe = max14577_charger_probe, > .remove = max14577_charger_remove, > -- > 2.17.1 >
diff --git a/drivers/power/supply/max14577_charger.c b/drivers/power/supply/max14577_charger.c index 8a59feac6468..96f4cd1941b2 100644 --- a/drivers/power/supply/max14577_charger.c +++ b/drivers/power/supply/max14577_charger.c @@ -623,9 +623,19 @@ static const struct platform_device_id max14577_charger_id[] = { }; MODULE_DEVICE_TABLE(platform, max14577_charger_id); +static const struct of_device_id of_max14577_charger_dt_match[] = { + { .compatible = "maxim,max14577-charger", + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, }, + { .compatible = "maxim,max77836-charger", + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, }, + { }, +}; +MODULE_DEVICE_TABLE(of, of_max14577_charger_dt_match); + static struct platform_driver max14577_charger_driver = { .driver = { .name = "max14577-charger", + .of_match_table = of_max14577_charger_dt_match, }, .probe = max14577_charger_probe, .remove = max14577_charger_remove,
Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- v3: - sorted of_max14577_charger_dt_match v2: - added .of_match_table pointer --- drivers/power/supply/max14577_charger.c | 10 ++++++++++ 1 file changed, 10 insertions(+)