| Message ID | 20200701032610.11944-1-xhao@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2] cpufreq: CPPC: fix some unreasonable codes in cppc_cpufreq_perf_to_khz() | expand |
On 01-07-20, 11:26, Xin Hao wrote: > The 'caps' variable has been defined, so there is no need to get > 'highest_perf' value through 'cpu->caps.highest_perf', you can use > 'caps->highest_perf' instead. > > Signed-off-by: Xin Hao <xhao@linux.alibaba.com> > --- > drivers/cpufreq/cppc_cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c > index 257d726a4456..444ee76a6bae 100644 > --- a/drivers/cpufreq/cppc_cpufreq.c > +++ b/drivers/cpufreq/cppc_cpufreq.c > @@ -161,7 +161,7 @@ static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu, > if (!max_khz) > max_khz = cppc_get_dmi_max_khz(); > mul = max_khz; > - div = cpu->perf_caps.highest_perf; > + div = caps->highest_perf; > } > return (u64)perf * mul / div; > } Applied. Thanks.
diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index 257d726a4456..444ee76a6bae 100644 --- a/drivers/cpufreq/cppc_cpufreq.c +++ b/drivers/cpufreq/cppc_cpufreq.c @@ -161,7 +161,7 @@ static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu, if (!max_khz) max_khz = cppc_get_dmi_max_khz(); mul = max_khz; - div = cpu->perf_caps.highest_perf; + div = caps->highest_perf; } return (u64)perf * mul / div; }
The 'caps' variable has been defined, so there is no need to get 'highest_perf' value through 'cpu->caps.highest_perf', you can use 'caps->highest_perf' instead. Signed-off-by: Xin Hao <xhao@linux.alibaba.com> --- drivers/cpufreq/cppc_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.24.1