| Message ID | 20210119140541.2453490-2-thara.gopinath@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: Replace thermal_notify_framework with thermal_zone_device_update | expand |
On 1/19/21 11:19 AM, Kalle Valo wrote: > Thara Gopinath <thara.gopinath@linaro.org> writes: > >> thermal_notify_framework just updates for a single trip point where as >> thermal_zone_device_update does other bookkeeping like updating the >> temperature of the thermal zone and setting the next trip point etc. >> Replace thermal_notify_framework with thermal_zone_device_update as the >> later is more thorough. >> >> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org> > > The title could be just "iwlwifi: mvm: tt: Replace > thermal_notify_framework". > > But via which tree is this going? I assume it's not > wireless-drivers-next so: Thanks for the quick review. I would say thermal. I will fix the subject and add your acked in the next version. > > Acked-by: Kalle Valo <kvalo@codeaurora.org> > >
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c index 507625f96dd7..a0c6be03903a 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c @@ -146,8 +146,8 @@ void iwl_mvm_temp_notif(struct iwl_mvm *mvm, struct iwl_rx_cmd_buffer *rxb) if (mvm->tz_device.tzone) { struct iwl_mvm_thermal_device *tz_dev = &mvm->tz_device; - thermal_notify_framework(tz_dev->tzone, - tz_dev->fw_trips_index[ths_crossed]); + thermal_zone_device_update(tz_dev->tzone, + THERMAL_TRIP_VIOLATED); } #endif /* CONFIG_THERMAL */ }
thermal_notify_framework just updates for a single trip point where as thermal_zone_device_update does other bookkeeping like updating the temperature of the thermal zone and setting the next trip point etc. Replace thermal_notify_framework with thermal_zone_device_update as the later is more thorough. Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org> --- drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)