| Message ID | 20210404125431.12208-1-zhuguangqing83@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | [v2] thermal/drivers/tsens: fix missing put_device error | expand |
On Sun 04 Apr 07:54 CDT 2021, zhuguangqing83@gmail.com wrote: > From: Guangqing Zhu <zhuguangqing83@gmail.com> > > Fixes coccicheck error: > > drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call > of_find_device_by_node on line 715, but without a corresponding object > release within this function. > > Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into > tsens.c") > > Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > v2: > - Fix a error(missing a bracket) in v1. > > --- > drivers/thermal/qcom/tsens.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index d8ce3a687b80..3c4c0516e58a 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -755,8 +755,10 @@ int __init init_common(struct tsens_priv *priv) > for (i = VER_MAJOR; i <= VER_STEP; i++) { > priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map, > priv->fields[i]); > - if (IS_ERR(priv->rf[i])) > - return PTR_ERR(priv->rf[i]); > + if (IS_ERR(priv->rf[i])) { > + ret = PTR_ERR(priv->rf[i]); > + goto err_put_device; > + } > } > ret = regmap_field_read(priv->rf[VER_MINOR], &ver_minor); > if (ret) > -- > 2.17.1 >
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index d8ce3a687b80..3c4c0516e58a 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -755,8 +755,10 @@ int __init init_common(struct tsens_priv *priv) for (i = VER_MAJOR; i <= VER_STEP; i++) { priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map, priv->fields[i]); - if (IS_ERR(priv->rf[i])) - return PTR_ERR(priv->rf[i]); + if (IS_ERR(priv->rf[i])) { + ret = PTR_ERR(priv->rf[i]); + goto err_put_device; + } } ret = regmap_field_read(priv->rf[VER_MINOR], &ver_minor); if (ret)