| Message ID | 20210420172308.134685-1-linux@fw-web.de (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | [v3] thermal: mediatek: add sensors-support | expand |
Hi, just a gentle ping ;) regards Frank > Gesendet: Dienstag, 20. April 2021 um 19:23 Uhr > Von: "Frank Wunderlich" <linux@fw-web.de> > An: linux-mediatek@lists.infradead.org > Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, "Amit Kucheria" <amitk@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org > Betreff: [PATCH v3] thermal: mediatek: add sensors-support > > From: Frank Wunderlich <frank-w@public-files.de> > > add HWMON-support to mediateks thermal driver to allow lm-sensors > userspace tools read soc temperature > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > v3: drop no_hwmon - now really, sorry > v2: drop ifdef and used devm_thermal_add_hwmon_sysfs > --- > drivers/thermal/mtk_thermal.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index 149c6d7fd5a0..85964988684b 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -23,6 +23,8 @@ > #include <linux/reset.h> > #include <linux/types.h> > > +#include "thermal_hwmon.h" > + > /* AUXADC Registers */ > #define AUXADC_CON1_SET_V 0x008 > #define AUXADC_CON1_CLR_V 0x00c > @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev) > goto err_disable_clk_peri_therm; > } > > + ret = devm_thermal_add_hwmon_sysfs(tzdev); > + if (ret) > + dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs"); > + > return 0; > > err_disable_clk_peri_therm: > -- > 2.25.1 > >
On 20/04/2021 19:23, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > add HWMON-support to mediateks thermal driver to allow lm-sensors > userspace tools read soc temperature > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > v3: drop no_hwmon - now really, sorry > v2: drop ifdef and used devm_thermal_add_hwmon_sysfs > --- > drivers/thermal/mtk_thermal.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index 149c6d7fd5a0..85964988684b 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -23,6 +23,8 @@ > #include <linux/reset.h> > #include <linux/types.h> > > +#include "thermal_hwmon.h" > + > /* AUXADC Registers */ > #define AUXADC_CON1_SET_V 0x008 > #define AUXADC_CON1_CLR_V 0x00c > @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev) > goto err_disable_clk_peri_therm; > } > > + ret = devm_thermal_add_hwmon_sysfs(tzdev); > + if (ret) > + dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs"); I think dev_warn() is more appropriate here. Regards, Matthias > + > return 0; > > err_disable_clk_peri_therm: >
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index 149c6d7fd5a0..85964988684b 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -23,6 +23,8 @@ #include <linux/reset.h> #include <linux/types.h> +#include "thermal_hwmon.h" + /* AUXADC Registers */ #define AUXADC_CON1_SET_V 0x008 #define AUXADC_CON1_CLR_V 0x00c @@ -1087,6 +1089,10 @@ static int mtk_thermal_probe(struct platform_device *pdev) goto err_disable_clk_peri_therm; } + ret = devm_thermal_add_hwmon_sysfs(tzdev); + if (ret) + dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs"); + return 0; err_disable_clk_peri_therm: