From patchwork Mon Sep 20 07:17:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12504685 X-Patchwork-Delegate: cw00.choi@samsung.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 397A5C4332F for ; Mon, 20 Sep 2021 07:18:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10C31610A8 for ; Mon, 20 Sep 2021 07:18:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234861AbhITHTf (ORCPT ); Mon, 20 Sep 2021 03:19:35 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:49468 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233294AbhITHTe (ORCPT ); Mon, 20 Sep 2021 03:19:34 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 425B13FE02 for ; Mon, 20 Sep 2021 07:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632122287; bh=g/5RG3r3yZseQXLqjOW/OPcxsvmzNDs0bMtIh+wjazo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qtl5f3NYKfIM6F21oFE4Tkh6GMTpFS1ZqSJiypv5t82McPDZr2wshHq1UV9yuC5dW tj5NCIoTFjKJM1WjvsXQ4sfsKq2GgIITzwrvMnRIxAQeNZWIFMmV+F3NVKvznIPe6Z e9HyHFWNwN2GtNX1U5CAjOrLDcwRgeq6n0hpC/XRximsLCerPCv5QRaW6KtSpBvgpL 25tnIEAxztOjeBiR8+yhCRU7BkocS7fHcynzlwsWN2qcvQCVsbC1Brl/hRqak5L43C IzCxNp6IRIht+P3hW7qOuFi3PDkRL1cepLSGU+y7GYauz/mgymq9z/21dFoiGCe8qN xDb0vVdbRLrWQ== Received: by mail-wm1-f69.google.com with SMTP id m9-20020a05600c4f4900b003057c761567so5420213wmq.1 for ; Mon, 20 Sep 2021 00:18:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g/5RG3r3yZseQXLqjOW/OPcxsvmzNDs0bMtIh+wjazo=; b=RNjOWh6n5Vmpn7IEvrejJkDHpBlTeaMpLFv5+VgXzhxsPigPb8ZwBQNprIJi/GNT1h L9w4iPWPj2atmXJLGj0q0557HsZ71lO2OPbGpjChCAfj1v3O7fz+Bi6QqGn/m+LGDKVs tJQfaIEeLYAUyceTszIPHBYqGKKmzIy/RFZXvHmznZ3IuZOhXfve+5UmwYRB6ZcTLslr QQEffJDTlKAniZhGJtbsSDHIPp/WoovCOD33gFEqa/A5u2/Qwwyaz0sJE6iZ5Lqve1Wk u6ykX444rruq1G/ZBya1Z4RQkEZ57LfIT9lLfqhSPeT9twwM6g9NJ7GGeZ2lqsYrf++B sn0g== X-Gm-Message-State: AOAM530HWVh13Tiq9Y9kmkgdG19IT3Rge/aaN1HBK0vbr6BXT4Z4KiZ3 30c8THaMh5lpkCeJrHduDUsIEYvXxA7vizeH0jqf8g731o2Tc2ItG585CeRsYhml6GCdJXyJBbW OIP3gNKxNW4Gks6kpbTpK65iqRAqIgwnhcZHg X-Received: by 2002:adf:b7c5:: with SMTP id t5mr26612607wre.322.1632122286574; Mon, 20 Sep 2021 00:18:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz09HTrwbItt4V4htloX64whzplHYzcpSmGaXTvrQepaoBp1J3Tpven9yjUCHjyNrL5/xX1aw== X-Received: by 2002:adf:b7c5:: with SMTP id t5mr26612589wre.322.1632122286380; Mon, 20 Sep 2021 00:18:06 -0700 (PDT) Received: from kozik-lap.lan (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id a202sm6990798wmd.15.2021.09.20.00.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 00:18:05 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz Subject: [PATCH v2 2/3] devfreq: exynos-ppmu: simplify parsing event-type from DT Date: Mon, 20 Sep 2021 09:17:52 +0200 Message-Id: <20210920071753.38560-2-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210920071540.38337-1-krzysztof.kozlowski@canonical.com> References: <20210920071540.38337-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org When parsing devicetree, the function of_get_devfreq_events(), for each device child node, iterates over array of possible events "ppmu_events" till it finds one matching by node name. When match is found the ppmu_events[i] points to element having both the name of the event and the counters ID. Each PPMU device child node might have an "event-name" property with the name of the event, however due to the design of devfreq it must be the same as the device node name. If it is not the same, the devfreq client won't be able to use it via devfreq_event_get_edev_by_phandle(). Since PPMU device child node name must be equal to the "event-name" property (event-name == ppmu_events[i].name), there is no need to find the counters ID by the "event-name". Instead use ppmu_events[i].id which must be equal to it. Signed-off-by: Krzysztof Kozlowski --- drivers/devfreq/event/exynos-ppmu.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index 541bd13ab61d..9b849d781116 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -566,13 +566,10 @@ static int of_get_devfreq_events(struct device_node *np, * use default if not. */ if (info->ppmu_type == EXYNOS_TYPE_PPMU_V2) { - int id; /* Not all registers take the same value for * read+write data count. */ - id = __exynos_ppmu_find_ppmu_id(desc[j].name); - - switch (id) { + switch (ppmu_events[i].id) { case PPMU_PMNCNT0: case PPMU_PMNCNT1: case PPMU_PMNCNT2: