| Message ID | 20210920071753.38560-3-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Chanwoo Choi |
| Headers | show |
| Series | devfreq: exynos-ppmu: conform to dt naming convention | expand |
Hi Krzysztof, On 9/20/21 4:17 PM, Krzysztof Kozlowski wrote: > Use hyphen instead of underscore and align the PPMU event node name with > dtschema. The event-name property must match the node name, by the > design of devfreq events and PPMU driver. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > arch/arm/boot/dts/exynos5420.dtsi | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index e23e8ffb093f..b2f30bea96ce 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -302,8 +302,8 @@ ppmu_dmc0_0: ppmu@10d00000 { > clocks = <&clock CLK_PCLK_PPMU_DREX0_0>; > clock-names = "ppmu"; > events { > - ppmu_event3_dmc0_0: ppmu-event3-dmc0_0 { > - event-name = "ppmu-event3-dmc0_0"; > + ppmu_event3_dmc0_0: ppmu-event3-dmc0-0 { > + event-name = "ppmu-event3-dmc0-0"; > }; > }; > }; > @@ -314,8 +314,8 @@ ppmu_dmc0_1: ppmu@10d10000 { > clocks = <&clock CLK_PCLK_PPMU_DREX0_1>; > clock-names = "ppmu"; > events { > - ppmu_event3_dmc0_1: ppmu-event3-dmc0_1 { > - event-name = "ppmu-event3-dmc0_1"; > + ppmu_event3_dmc0_1: ppmu-event3-dmc0-1 { > + event-name = "ppmu-event3-dmc0-1"; > }; > }; > }; > @@ -326,8 +326,8 @@ ppmu_dmc1_0: ppmu@10d60000 { > clocks = <&clock CLK_PCLK_PPMU_DREX1_0>; > clock-names = "ppmu"; > events { > - ppmu_event3_dmc1_0: ppmu-event3-dmc1_0 { > - event-name = "ppmu-event3-dmc1_0"; > + ppmu_event3_dmc1_0: ppmu-event3-dmc1-0 { > + event-name = "ppmu-event3-dmc1-0"; > }; > }; > }; > @@ -338,8 +338,8 @@ ppmu_dmc1_1: ppmu@10d70000 { > clocks = <&clock CLK_PCLK_PPMU_DREX1_1>; > clock-names = "ppmu"; > events { > - ppmu_event3_dmc1_1: ppmu-event3-dmc1_1 { > - event-name = "ppmu-event3-dmc1_1"; > + ppmu_event3_dmc1_1: ppmu-event3-dmc1-1 { > + event-name = "ppmu-event3-dmc1-1"; > }; > }; > }; > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
On Mon, 20 Sep 2021 09:17:53 +0200, Krzysztof Kozlowski wrote: > Use hyphen instead of underscore and align the PPMU event node name with > dtschema. The event-name property must match the node name, by the > design of devfreq events and PPMU driver. > > Applied, thanks! [3/3] ARM: dts: exynos: align PPMU event node names with dtschema commit: 7cdfe3b3b60c89f0e12e8ee194a7cfbfd46515dd Best regards,
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index e23e8ffb093f..b2f30bea96ce 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -302,8 +302,8 @@ ppmu_dmc0_0: ppmu@10d00000 { clocks = <&clock CLK_PCLK_PPMU_DREX0_0>; clock-names = "ppmu"; events { - ppmu_event3_dmc0_0: ppmu-event3-dmc0_0 { - event-name = "ppmu-event3-dmc0_0"; + ppmu_event3_dmc0_0: ppmu-event3-dmc0-0 { + event-name = "ppmu-event3-dmc0-0"; }; }; }; @@ -314,8 +314,8 @@ ppmu_dmc0_1: ppmu@10d10000 { clocks = <&clock CLK_PCLK_PPMU_DREX0_1>; clock-names = "ppmu"; events { - ppmu_event3_dmc0_1: ppmu-event3-dmc0_1 { - event-name = "ppmu-event3-dmc0_1"; + ppmu_event3_dmc0_1: ppmu-event3-dmc0-1 { + event-name = "ppmu-event3-dmc0-1"; }; }; }; @@ -326,8 +326,8 @@ ppmu_dmc1_0: ppmu@10d60000 { clocks = <&clock CLK_PCLK_PPMU_DREX1_0>; clock-names = "ppmu"; events { - ppmu_event3_dmc1_0: ppmu-event3-dmc1_0 { - event-name = "ppmu-event3-dmc1_0"; + ppmu_event3_dmc1_0: ppmu-event3-dmc1-0 { + event-name = "ppmu-event3-dmc1-0"; }; }; }; @@ -338,8 +338,8 @@ ppmu_dmc1_1: ppmu@10d70000 { clocks = <&clock CLK_PCLK_PPMU_DREX1_1>; clock-names = "ppmu"; events { - ppmu_event3_dmc1_1: ppmu-event3-dmc1_1 { - event-name = "ppmu-event3-dmc1_1"; + ppmu_event3_dmc1_1: ppmu-event3-dmc1-1 { + event-name = "ppmu-event3-dmc1-1"; }; }; };
Use hyphen instead of underscore and align the PPMU event node name with dtschema. The event-name property must match the node name, by the design of devfreq events and PPMU driver. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- arch/arm/boot/dts/exynos5420.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)