| Message ID | 20210920203849.32136-1-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: thermal_mmio: Constify static struct thermal_mmio_ops | expand |
The only usage of thermal_mmio_ops is to pass its address to > devm_thermal_zone_of_sensor_register(), which has a pointer to const > struct thermal_zone_of_device_ops as argument. Make it const to allow > the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Acked-by: Talel Shenhar <talel@amazon.com> > --- > drivers/thermal/thermal_mmio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c > index ded1dd0d4ef7..360b0dfdc3b0 100644 > --- a/drivers/thermal/thermal_mmio.c > +++ b/drivers/thermal/thermal_mmio.c > @@ -34,7 +34,7 @@ static int thermal_mmio_get_temperature(void *private, int *temp) > return 0; > } > > -static struct thermal_zone_of_device_ops thermal_mmio_ops = { > +static const struct thermal_zone_of_device_ops thermal_mmio_ops = { > .get_temp = thermal_mmio_get_temperature, > }; > > -- > 2.33.0 >
On Tue, Sep 21, 2021 at 3:55 AM Rikard Falkeborn <rikard.falkeborn@gmail.com> wrote: > > The only usage of thermal_mmio_ops is to pass its address to > devm_thermal_zone_of_sensor_register(), which has a pointer to const > struct thermal_zone_of_device_ops as argument. Make it const to allow > the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > --- > drivers/thermal/thermal_mmio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c > index ded1dd0d4ef7..360b0dfdc3b0 100644 > --- a/drivers/thermal/thermal_mmio.c > +++ b/drivers/thermal/thermal_mmio.c > @@ -34,7 +34,7 @@ static int thermal_mmio_get_temperature(void *private, int *temp) > return 0; > } > > -static struct thermal_zone_of_device_ops thermal_mmio_ops = { > +static const struct thermal_zone_of_device_ops thermal_mmio_ops = { > .get_temp = thermal_mmio_get_temperature, > }; > > -- I'm not sure what happened to this patch. Daniel, are you going to pick it up?
On 05/10/2021 16:36, Rafael J. Wysocki wrote: > On Tue, Sep 21, 2021 at 3:55 AM Rikard Falkeborn > <rikard.falkeborn@gmail.com> wrote: >> >> The only usage of thermal_mmio_ops is to pass its address to >> devm_thermal_zone_of_sensor_register(), which has a pointer to const >> struct thermal_zone_of_device_ops as argument. Make it const to allow >> the compiler to put it in read-only memory. >> >> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> >> --- >> drivers/thermal/thermal_mmio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c >> index ded1dd0d4ef7..360b0dfdc3b0 100644 >> --- a/drivers/thermal/thermal_mmio.c >> +++ b/drivers/thermal/thermal_mmio.c >> @@ -34,7 +34,7 @@ static int thermal_mmio_get_temperature(void *private, int *temp) >> return 0; >> } >> >> -static struct thermal_zone_of_device_ops thermal_mmio_ops = { >> +static const struct thermal_zone_of_device_ops thermal_mmio_ops = { >> .get_temp = thermal_mmio_get_temperature, >> }; >> >> -- > > I'm not sure what happened to this patch. > > Daniel, are you going to pick it up? Yes. I had picked also the intel ones but I'll drop them.
diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c index ded1dd0d4ef7..360b0dfdc3b0 100644 --- a/drivers/thermal/thermal_mmio.c +++ b/drivers/thermal/thermal_mmio.c @@ -34,7 +34,7 @@ static int thermal_mmio_get_temperature(void *private, int *temp) return 0; } -static struct thermal_zone_of_device_ops thermal_mmio_ops = { +static const struct thermal_zone_of_device_ops thermal_mmio_ops = { .get_temp = thermal_mmio_get_temperature, };
The only usage of thermal_mmio_ops is to pass its address to devm_thermal_zone_of_sensor_register(), which has a pointer to const struct thermal_zone_of_device_ops as argument. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/thermal/thermal_mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)