| Message ID | 20210927095150.944127-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | cpufreq: s3c244x: add fallthrough comments for switch | expand |
On 27/09/2021 11:51, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Apparently nobody has so far caught this warning, I hit it in randconfig > build testing: > > drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs': > drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here > case 3: > ^~~~ > drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here > case 4: > ^~~~ > > Both look like the fallthrough is intentional, so add the new > "fallthrough;" keyword. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/cpufreq/s3c2440-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) I think I saw it but back then implicit-fallthrough was not an error :) LGTM: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On 27-09-21, 11:51, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Apparently nobody has so far caught this warning, I hit it in randconfig > build testing: > > drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs': > drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here > case 3: > ^~~~ > drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here > case 4: > ^~~~ > > Both look like the fallthrough is intentional, so add the new > "fallthrough;" keyword. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/cpufreq/s3c2440-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c > index 148e8aedefa9..2011fb9c03a4 100644 > --- a/drivers/cpufreq/s3c2440-cpufreq.c > +++ b/drivers/cpufreq/s3c2440-cpufreq.c > @@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg) > > case 6: > camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; > + fallthrough; > case 3: > clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6; > break; > > case 8: > camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; > + fallthrough; > case 4: > clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8; > break; Applied. Thanks.
diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c index 148e8aedefa9..2011fb9c03a4 100644 --- a/drivers/cpufreq/s3c2440-cpufreq.c +++ b/drivers/cpufreq/s3c2440-cpufreq.c @@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg) case 6: camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; + fallthrough; case 3: clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6; break; case 8: camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; + fallthrough; case 4: clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8; break;