| Message ID | 20211004112550.27546-2-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: k3_j72xx_bandgap: Add the bandgap driver support | expand |
On Mon, 04 Oct 2021 16:55:47 +0530, Keerthy wrote: > Add VTM bindings documentation. In the Voltage Thermal > Management Module(VTM), K3 J72XX supplies a voltage > reference and a temperature sensor feature that are gathered in the band > gap voltage and temperature sensor (VBGAPTS) module. The band > gap provides current and voltage reference for its internal > circuits and other analog IP blocks. The analog-to-digital > converter (ADC) produces an output value that is proportional > to the silicon temperature. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > .../bindings/thermal/ti,j72xx-thermal.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dt.yaml: example-0: wkup_vtm0@42040000:reg:0: [0, 1107558400, 0, 848] is too long From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dt.yaml: example-0: wkup_vtm0@42040000:reg:1: [0, 1107623936, 0, 848] is too long From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dt.yaml: example-0: wkup_vtm0@42040000:reg:2: [0, 1124074240, 0, 16] is too long From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dt.yaml: wkup_vtm0@42040000: compatible: ['ti,j721e-vtm', 'ti,j7200-vtm'] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dt.yaml: wkup_vtm0@42040000: compatible: Additional items are not allowed ('ti,j7200-vtm' was unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dt.yaml:0:0: /example-0/wkup_vtm0@42040000: failed to match any schema with compatible: ['ti,j721e-vtm', 'ti,j7200-vtm'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1536069 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Tue, Oct 5, 2021 at 7:26 AM Rob Herring <robh@kernel.org> wrote: > > On Mon, 04 Oct 2021 16:55:47 +0530, Keerthy wrote: > > Add VTM bindings documentation. In the Voltage Thermal > > Management Module(VTM), K3 J72XX supplies a voltage > > reference and a temperature sensor feature that are gathered in the band > > gap voltage and temperature sensor (VBGAPTS) module. The band > > gap provides current and voltage reference for its internal > > circuits and other analog IP blocks. The analog-to-digital > > converter (ADC) produces an output value that is proportional > > to the silicon temperature. > > > > Signed-off-by: Keerthy <j-keerthy@ti.com> > > --- > > .../bindings/thermal/ti,j72xx-thermal.yaml | 58 +++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): Woot, TI has blacklisted me: The response from the remote server was: 553 Sorry, your email address has been blacklisted. Please contact Texas Instruments Inc to have yourself removed.
Keerthy, did you receive this answer ? On 05/10/2021 15:05, Rob Herring wrote: > On Tue, Oct 5, 2021 at 7:26 AM Rob Herring <robh@kernel.org> wrote: >> >> On Mon, 04 Oct 2021 16:55:47 +0530, Keerthy wrote: >>> Add VTM bindings documentation. In the Voltage Thermal >>> Management Module(VTM), K3 J72XX supplies a voltage >>> reference and a temperature sensor feature that are gathered in the band >>> gap voltage and temperature sensor (VBGAPTS) module. The band >>> gap provides current and voltage reference for its internal >>> circuits and other analog IP blocks. The analog-to-digital >>> converter (ADC) produces an output value that is proportional >>> to the silicon temperature. >>> >>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>> --- >>> .../bindings/thermal/ti,j72xx-thermal.yaml | 58 +++++++++++++++++++ >>> 1 file changed, 58 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > > Woot, TI has blacklisted me: > > The response from the remote server was: > 553 Sorry, your email address has been blacklisted. Please contact > Texas Instruments Inc to have yourself removed. >
On 10/6/2021 3:12 PM, Daniel Lezcano wrote: > > Keerthy, > > did you receive this answer ? Daniel, Thanks for sending this. I did not receive Rob's responses. Rob, Apologies. I will get this rectified before i send the V2 with the reported issue fixed. It seems issue with my particular e-mail account. Apologies for the inconvenience once again! Best Regards, Keerthy > > > On 05/10/2021 15:05, Rob Herring wrote: >> On Tue, Oct 5, 2021 at 7:26 AM Rob Herring <robh@kernel.org> wrote: >>> >>> On Mon, 04 Oct 2021 16:55:47 +0530, Keerthy wrote: >>>> Add VTM bindings documentation. In the Voltage Thermal >>>> Management Module(VTM), K3 J72XX supplies a voltage >>>> reference and a temperature sensor feature that are gathered in the band >>>> gap voltage and temperature sensor (VBGAPTS) module. The band >>>> gap provides current and voltage reference for its internal >>>> circuits and other analog IP blocks. The analog-to-digital >>>> converter (ADC) produces an output value that is proportional >>>> to the silicon temperature. >>>> >>>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>>> --- >>>> .../bindings/thermal/ti,j72xx-thermal.yaml | 58 +++++++++++++++++++ >>>> 1 file changed, 58 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml >>>> >>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> Woot, TI has blacklisted me: >> >> The response from the remote server was: >> 553 Sorry, your email address has been blacklisted. Please contact >> Texas Instruments Inc to have yourself removed. >> > >
diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml new file mode 100644 index 000000000000..ccf1bd3640ee --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments J72XX VTM (DTS) binding + +maintainers: + - Keerthy <j-keerthy@ti.com> + +properties: + compatible: + const: ti,j721e-vtm + + reg: + maxItems: 3 + + power-domains: + maxItems: 1 + + "#thermal-sensor-cells": + const: 1 + +required: + - compatible + - reg + - power-domains + - "#thermal-sensor-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/soc/ti,sci_pm_domain.h> + wkup_vtm0: wkup_vtm0@42040000 { + compatible = "ti,j721e-vtm", "ti,j7200-vtm"; + reg = <0x0 0x42040000 0x0 0x350>, + <0x0 0x42050000 0x0 0x350>, + <0x0 0x43000300 0x0 0x10>; + power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>; + #thermal-sensor-cells = <1>; + }; + + mpu_thermal: mpu_thermal { + polling-delay-passive = <250>; /* milliseconds */ + polling-delay = <500>; /* milliseconds */ + thermal-sensors = <&wkup_vtm0 0>; + + trips { + mpu_crit: mpu_crit { + temperature = <125000>; /* milliCelsius */ + hysteresis = <2000>; /* milliCelsius */ + type = "critical"; + }; + }; + }; +...
Add VTM bindings documentation. In the Voltage Thermal Management Module(VTM), K3 J72XX supplies a voltage reference and a temperature sensor feature that are gathered in the band gap voltage and temperature sensor (VBGAPTS) module. The band gap provides current and voltage reference for its internal circuits and other analog IP blocks. The analog-to-digital converter (ADC) produces an output value that is proportional to the silicon temperature. Signed-off-by: Keerthy <j-keerthy@ti.com> --- .../bindings/thermal/ti,j72xx-thermal.yaml | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml