| Message ID | 20220107030433.2381616-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | dt-bindings: power: maxim,max17040: Fix incorrect type for 'maxim,rcomp' | expand |
On 07/01/2022 04:04, Rob Herring wrote: > The 'maxim,rcomp' is defined as a uint32, but the description and users all > say it is uint8-array with 1 or 2 elements. The tools missed checking this > case. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/power/supply/maxim,max17040.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml index ffb344987a7b..6b4588a3253b 100644 --- a/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17040.yaml @@ -44,7 +44,9 @@ properties: SoC == State of Charge == Capacity. maxim,rcomp: - $ref: /schemas/types.yaml#/definitions/uint32 + $ref: /schemas/types.yaml#/definitions/uint8-array + minItems: 1 + maxItems: 2 description: | A value to compensate readings for various battery chemistries and operating temperatures. max17040,41 have 2 byte rcomp, default to 0x97 0x00.
The 'maxim,rcomp' is defined as a uint32, but the description and users all say it is uint8-array with 1 or 2 elements. The tools missed checking this case. Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/power/supply/maxim,max17040.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)