| Message ID | 20220425033355.6281-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | cpuidle: tegra: restrict to ARCH_SUSPEND_POSSIBLE | expand |
On Mon, Apr 25, 2022 at 5:33 AM Randy Dunlap <rdunlap@infradead.org> wrote: > > Since 'select' does not follow any dependency chain (ARM_CPU_SUSPEND > in this case), make ARM_TEGRA_CPUIDLE depend on ARCH_SUSPEND_POSSIBLE, > just as ARM_CPU_SUSPEND does. > > Fix this kconfig warning: > > WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND > Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n] > Selected by [y]: > - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y] > > and subsequent build errors: > > arm-linux-gnueabi-ld: arch/arm/kernel/sleep.o: in function `__cpu_suspend': > (.text+0x68): undefined reference to `cpu_sa110_suspend_size' > arm-linux-gnueabi-ld: arch/arm/kernel/suspend.o: in function `__cpu_suspend_save': > suspend.c:(.text+0x478): undefined reference to `cpu_sa110_do_suspend' > arm-linux-gnueabi-ld: suspend.c:(.text+0x4e8): undefined reference to `cpu_sa110_do_resume' > > Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Dmitry Osipenko <digetx@gmail.com> > Cc: Thierry Reding <treding@nvidia.com> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: linux-pm@vger.kernel.org Looks correct to me, Reviewed-by: Arnd Bergmann <arnd@arndb.de>
--- a/drivers/cpuidle/Kconfig.arm +++ b/drivers/cpuidle/Kconfig.arm @@ -101,6 +101,7 @@ config ARM_MVEBU_V7_CPUIDLE config ARM_TEGRA_CPUIDLE bool "CPU Idle Driver for NVIDIA Tegra SoCs" depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU + depends on ARCH_SUSPEND_POSSIBLE select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP select ARM_CPU_SUSPEND help
Since 'select' does not follow any dependency chain (ARM_CPU_SUSPEND in this case), make ARM_TEGRA_CPUIDLE depend on ARCH_SUSPEND_POSSIBLE, just as ARM_CPU_SUSPEND does. Fix this kconfig warning: WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n] Selected by [y]: - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y] and subsequent build errors: arm-linux-gnueabi-ld: arch/arm/kernel/sleep.o: in function `__cpu_suspend': (.text+0x68): undefined reference to `cpu_sa110_suspend_size' arm-linux-gnueabi-ld: arch/arm/kernel/suspend.o: in function `__cpu_suspend_save': suspend.c:(.text+0x478): undefined reference to `cpu_sa110_do_suspend' arm-linux-gnueabi-ld: suspend.c:(.text+0x4e8): undefined reference to `cpu_sa110_do_resume' Fixes: faae6c9f2e68 ("cpuidle: tegra: Enable compile testing") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Dmitry Osipenko <digetx@gmail.com> Cc: Thierry Reding <treding@nvidia.com> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: linux-pm@vger.kernel.org --- drivers/cpuidle/Kconfig.arm | 1 + 1 file changed, 1 insertion(+)