| Message ID | 20220505124241.1590861-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: broadcom: check return value after calling platform_get_resource() | expand |
diff --git a/drivers/thermal/broadcom/sr-thermal.c b/drivers/thermal/broadcom/sr-thermal.c index 475ce2900771..799128deb91c 100644 --- a/drivers/thermal/broadcom/sr-thermal.c +++ b/drivers/thermal/broadcom/sr-thermal.c @@ -60,6 +60,8 @@ static int sr_thermal_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; sr_thermal->regs = (void __iomem *)devm_memremap(&pdev->dev, res->start, resource_size(res), MEMREMAP_WB);
It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Fixes: 250e211057c7 ("thermal: broadcom: Add Stingray thermal driver") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/thermal/broadcom/sr-thermal.c | 2 ++ 1 file changed, 2 insertions(+)