| Message ID | 20220525151040.24024-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support | expand |
Hi Wolfram, Thanks for your work. On 2022-05-25 17:10:40 +0200, Wolfram Sang wrote: > Add support for R-Car S4. The S4 IP differs a bit from its siblings in > such way that it has 3 out of 4 TSC nodes for Linux and the interrupts > are not routed to the INTC-AP but to the ECM. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > index 1368d90da0e8..b863c0a935ec 100644 > --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > @@ -8,9 +8,10 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: Renesas R-Car Gen3 Thermal Sensor > > description: > - On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal > - sensors (THS) which are the analog circuits for measuring temperature (Tj) > - inside the LSI. > + > + On most R-Car Gen3 and later SoCs, the thermal sensor controllers (TSC) > + control the thermal sensors (THS) which are the analog circuits for > + measuring temperature (Tj) inside the LSI. > > maintainers: > - Niklas Söderlund <niklas.soderlund@ragnatech.se> > @@ -27,6 +28,7 @@ properties: > - renesas,r8a77965-thermal # R-Car M3-N > - renesas,r8a77980-thermal # R-Car V3H > - renesas,r8a779a0-thermal # R-Car V3U > + - renesas,r8a779f0-thermal # R-Car S4 > > reg: true > > -- > 2.35.1 >
On Wed, 25 May 2022 17:10:40 +0200, Wolfram Sang wrote: > Add support for R-Car S4. The S4 IP differs a bit from its siblings in > such way that it has 3 out of 4 TSC nodes for Linux and the interrupts > are not routed to the INTC-AP but to the ECM. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi Wolfram, On Wed, May 25, 2022 at 5:42 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Add support for R-Car S4. The S4 IP differs a bit from its siblings in > such way that it has 3 out of 4 TSC nodes for Linux and the interrupts > are not routed to the INTC-AP but to the ECM. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > @@ -8,9 +8,10 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: Renesas R-Car Gen3 Thermal Sensor > > description: > - On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal > - sensors (THS) which are the analog circuits for measuring temperature (Tj) > - inside the LSI. > + > + On most R-Car Gen3 and later SoCs, the thermal sensor controllers (TSC) > + control the thermal sensors (THS) which are the analog circuits for > + measuring temperature (Tj) inside the LSI. > > maintainers: > - Niklas Söderlund <niklas.soderlund@ragnatech.se> > @@ -27,6 +28,7 @@ properties: > - renesas,r8a77965-thermal # R-Car M3-N > - renesas,r8a77980-thermal # R-Car V3H > - renesas,r8a779a0-thermal # R-Car V3U > + - renesas,r8a779f0-thermal # R-Car S4 > > reg: true As the interrupt is routed to the ECM, like on R-Car V3U, the interrupts property should not be required. Else "make dtbs_check" complains: arch/arm64/boot/dts/renesas/r8a779f0-spider.dtb: thermal@e6198000: 'interrupts' is a required property Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml index 1368d90da0e8..b863c0a935ec 100644 --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml @@ -8,9 +8,10 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Renesas R-Car Gen3 Thermal Sensor description: - On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal - sensors (THS) which are the analog circuits for measuring temperature (Tj) - inside the LSI. + + On most R-Car Gen3 and later SoCs, the thermal sensor controllers (TSC) + control the thermal sensors (THS) which are the analog circuits for + measuring temperature (Tj) inside the LSI. maintainers: - Niklas Söderlund <niklas.soderlund@ragnatech.se> @@ -27,6 +28,7 @@ properties: - renesas,r8a77965-thermal # R-Car M3-N - renesas,r8a77980-thermal # R-Car V3H - renesas,r8a779a0-thermal # R-Car V3U + - renesas,r8a779f0-thermal # R-Car S4 reg: true
Add support for R-Car S4. The S4 IP differs a bit from its siblings in such way that it has 3 out of 4 TSC nodes for Linux and the interrupts are not routed to the INTC-AP but to the ECM. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)