| Message ID | 20220609194154.12829-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | [v2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779f0 support | expand |
Hi Wolfram, On Thu, Jun 9, 2022 at 10:04 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Add support for R-Car S4. The S4 IP differs a bit from its siblings in > such way that it has 3 out of 4 TSC nodes for Linux and the interrupts > are not routed to the INTC-AP but to the ECM. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Change since v1: > > * Describe that this SoC does not require interrupts (Thanks, Geert!) > > I hope dtbs_check is happy now. I can't test it because I get tons of > python install errors when trying to update my dtschema :( Unfortunately not: arch/arm64/boot/dts/renesas/r8a779f0-spider.dtb: thermal@e6198000: reg: [[0, 3860430848, 0, 512], [0, 3860463616, 0, 512], [0, 3860496384, 0, 512]] is too short > --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > @@ -8,9 +8,10 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: Renesas R-Car Gen3 Thermal Sensor > > description: > - On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal > - sensors (THS) which are the analog circuits for measuring temperature (Tj) > - inside the LSI. > + > + On most R-Car Gen3 and later SoCs, the thermal sensor controllers (TSC) > + control the thermal sensors (THS) which are the analog circuits for > + measuring temperature (Tj) inside the LSI. > > maintainers: > - Niklas Söderlund <niklas.soderlund@ragnatech.se> > @@ -27,6 +28,7 @@ properties: > - renesas,r8a77965-thermal # R-Car M3-N > - renesas,r8a77980-thermal # R-Car V3H > - renesas,r8a779a0-thermal # R-Car V3U > + - renesas,r8a779f0-thermal # R-Car S4 > > reg: true > > @@ -63,6 +65,7 @@ if: > contains: > enum: > - renesas,r8a779a0-thermal > + - renesas,r8a779f0-thermal As this controls both the presence of interrupts and the number of regs. > then: > properties: > reg: Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> Unfortunately not: > > arch/arm64/boot/dts/renesas/r8a779f0-spider.dtb: thermal@e6198000: > reg: [[0, 3860430848, 0, 512], [0, 3860463616, 0, 512], [0, > 3860496384, 0, 512]] is too short Okay, I managed to find the missing dependency to finally update my dtschema. I'll send a new version which I then tested myself.
diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml index 1368d90da0e8..08001d6fa67c 100644 --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml @@ -8,9 +8,10 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Renesas R-Car Gen3 Thermal Sensor description: - On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal - sensors (THS) which are the analog circuits for measuring temperature (Tj) - inside the LSI. + + On most R-Car Gen3 and later SoCs, the thermal sensor controllers (TSC) + control the thermal sensors (THS) which are the analog circuits for + measuring temperature (Tj) inside the LSI. maintainers: - Niklas Söderlund <niklas.soderlund@ragnatech.se> @@ -27,6 +28,7 @@ properties: - renesas,r8a77965-thermal # R-Car M3-N - renesas,r8a77980-thermal # R-Car V3H - renesas,r8a779a0-thermal # R-Car V3U + - renesas,r8a779f0-thermal # R-Car S4 reg: true @@ -63,6 +65,7 @@ if: contains: enum: - renesas,r8a779a0-thermal + - renesas,r8a779f0-thermal then: properties: reg:
Add support for R-Car S4. The S4 IP differs a bit from its siblings in such way that it has 3 out of 4 TSC nodes for Linux and the interrupts are not routed to the INTC-AP but to the ECM. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Change since v1: * Describe that this SoC does not require interrupts (Thanks, Geert!) I hope dtbs_check is happy now. I can't test it because I get tons of python install errors when trying to update my dtschema :( .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)