| Message ID | 20220610201701.7946-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | [v3,1/2] dt-bindings: thermal: rcar-gen3-thermal: use positive logic | expand |
Hi Wolfram, Thanks for your patch. On 2022-06-10 22:17:00 +0200, Wolfram Sang wrote: > When handling the V3U/r8a779a0 exception, avoid using 'not:' because > then its subschemas are far away in the 'else:' branch. Keep them > together using positive logic. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > > Changes since v2: > * new patch > > Tested with: > make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml > > .../bindings/thermal/rcar-gen3-thermal.yaml | 21 +++++++++---------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > index 1368d90da0e8..72dc7eb27f8d 100644 > --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > @@ -57,31 +57,30 @@ required: > - "#thermal-sensor-cells" > > if: > - not: > - properties: > - compatible: > - contains: > - enum: > - - renesas,r8a779a0-thermal > + properties: > + compatible: > + contains: > + enum: > + - renesas,r8a779a0-thermal > then: > properties: > reg: > - minItems: 2 > items: > + - description: TSC0 registers > - description: TSC1 registers > - description: TSC2 registers > - description: TSC3 registers > - required: > - - interrupts > + - description: TSC4 registers > else: > properties: > reg: > + minItems: 2 > items: > - - description: TSC0 registers > - description: TSC1 registers > - description: TSC2 registers > - description: TSC3 registers > - - description: TSC4 registers > + required: > + - interrupts > > additionalProperties: false > > -- > 2.35.1 >
On Fri, Jun 10, 2022 at 10:18 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > When handling the V3U/r8a779a0 exception, avoid using 'not:' because > then its subschemas are far away in the 'else:' branch. Keep them > together using positive logic. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Changes since v2: > * new patch Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Tested with: > make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml And dt_binding_check? Yep, it succeeds ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 10/06/2022 22:17, Wolfram Sang wrote: > When handling the V3U/r8a779a0 exception, avoid using 'not:' because > then its subschemas are far away in the 'else:' branch. Keep them > together using positive logic. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Changes since v2: > * new patch > > Tested with: > make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml > > .../bindings/thermal/rcar-gen3-thermal.yaml | 21 +++++++++---------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > index 1368d90da0e8..72dc7eb27f8d 100644 > --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml > @@ -57,31 +57,30 @@ required: > - "#thermal-sensor-cells" Applied, thanks
diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml index 1368d90da0e8..72dc7eb27f8d 100644 --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml @@ -57,31 +57,30 @@ required: - "#thermal-sensor-cells" if: - not: - properties: - compatible: - contains: - enum: - - renesas,r8a779a0-thermal + properties: + compatible: + contains: + enum: + - renesas,r8a779a0-thermal then: properties: reg: - minItems: 2 items: + - description: TSC0 registers - description: TSC1 registers - description: TSC2 registers - description: TSC3 registers - required: - - interrupts + - description: TSC4 registers else: properties: reg: + minItems: 2 items: - - description: TSC0 registers - description: TSC1 registers - description: TSC2 registers - description: TSC3 registers - - description: TSC4 registers + required: + - interrupts additionalProperties: false
When handling the V3U/r8a779a0 exception, avoid using 'not:' because then its subschemas are far away in the 'else:' branch. Keep them together using positive logic. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Changes since v2: * new patch Tested with: make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml .../bindings/thermal/rcar-gen3-thermal.yaml | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-)