Message ID | 20220721043608.1527686-2-martin.kepplinger@puri.sm (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | power: domain: handle power supplies that need interrupts | expand |
On Thu, 21 Jul 2022 at 06:36, Martin Kepplinger <martin.kepplinger@puri.sm> wrote: > > Use the BIT macro for flags and simply do 2 tags indentation. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> I prefer to keep the advantages with doing a git blame on this file, over this cleanup. Unless you feel strongly about this I would appreciate it if you can drop $subject patch from the series. Kind regards Uffe > --- > include/linux/pm_domain.h | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h > index ebc351698090..76bc9e3ef5ff 100644 > --- a/include/linux/pm_domain.h > +++ b/include/linux/pm_domain.h > @@ -8,6 +8,7 @@ > #ifndef _LINUX_PM_DOMAIN_H > #define _LINUX_PM_DOMAIN_H > > +#include <linux/bits.h> > #include <linux/device.h> > #include <linux/ktime.h> > #include <linux/mutex.h> > @@ -61,13 +62,13 @@ > * components' next wakeup when determining the > * optimal idle state. > */ > -#define GENPD_FLAG_PM_CLK (1U << 0) > -#define GENPD_FLAG_IRQ_SAFE (1U << 1) > -#define GENPD_FLAG_ALWAYS_ON (1U << 2) > -#define GENPD_FLAG_ACTIVE_WAKEUP (1U << 3) > -#define GENPD_FLAG_CPU_DOMAIN (1U << 4) > -#define GENPD_FLAG_RPM_ALWAYS_ON (1U << 5) > -#define GENPD_FLAG_MIN_RESIDENCY (1U << 6) > +#define GENPD_FLAG_PM_CLK BIT(0) > +#define GENPD_FLAG_IRQ_SAFE BIT(1) > +#define GENPD_FLAG_ALWAYS_ON BIT(2) > +#define GENPD_FLAG_ACTIVE_WAKEUP BIT(3) > +#define GENPD_FLAG_CPU_DOMAIN BIT(4) > +#define GENPD_FLAG_RPM_ALWAYS_ON BIT(5) > +#define GENPD_FLAG_MIN_RESIDENCY BIT(6) > > enum gpd_status { > GENPD_STATE_ON = 0, /* PM domain is on */ > -- > 2.30.2 >
diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index ebc351698090..76bc9e3ef5ff 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -8,6 +8,7 @@ #ifndef _LINUX_PM_DOMAIN_H #define _LINUX_PM_DOMAIN_H +#include <linux/bits.h> #include <linux/device.h> #include <linux/ktime.h> #include <linux/mutex.h> @@ -61,13 +62,13 @@ * components' next wakeup when determining the * optimal idle state. */ -#define GENPD_FLAG_PM_CLK (1U << 0) -#define GENPD_FLAG_IRQ_SAFE (1U << 1) -#define GENPD_FLAG_ALWAYS_ON (1U << 2) -#define GENPD_FLAG_ACTIVE_WAKEUP (1U << 3) -#define GENPD_FLAG_CPU_DOMAIN (1U << 4) -#define GENPD_FLAG_RPM_ALWAYS_ON (1U << 5) -#define GENPD_FLAG_MIN_RESIDENCY (1U << 6) +#define GENPD_FLAG_PM_CLK BIT(0) +#define GENPD_FLAG_IRQ_SAFE BIT(1) +#define GENPD_FLAG_ALWAYS_ON BIT(2) +#define GENPD_FLAG_ACTIVE_WAKEUP BIT(3) +#define GENPD_FLAG_CPU_DOMAIN BIT(4) +#define GENPD_FLAG_RPM_ALWAYS_ON BIT(5) +#define GENPD_FLAG_MIN_RESIDENCY BIT(6) enum gpd_status { GENPD_STATE_ON = 0, /* PM domain is on */
Use the BIT macro for flags and simply do 2 tags indentation. Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> --- include/linux/pm_domain.h | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)