diff mbox series

thermal/core: Add missing EXPORT_SYMBOL_GPL

Message ID 20220810100731.749317-1-daniel.lezcano@linaro.org (mailing list archive)
State New, archived
Delegated to: Daniel Lezcano
Headers show
Series thermal/core: Add missing EXPORT_SYMBOL_GPL | expand

Commit Message

Daniel Lezcano Aug. 10, 2022, 10:07 a.m. UTC
The function thermal_zone_device_register_with_trips() is not exported
for modules.

Add the missing EXPORT_SYMBOL_GPL().

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/thermal_core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rafael J. Wysocki Aug. 10, 2022, 11:58 a.m. UTC | #1
On Wed, Aug 10, 2022 at 12:07 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> The function thermal_zone_device_register_with_trips() is not exported
> for modules.
>
> Add the missing EXPORT_SYMBOL_GPL().
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

A Fixes tag missing?

> ---
>  drivers/thermal/thermal_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index b4c68410c158..10c979dce512 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1329,6 +1329,7 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
>         kfree(tz);
>         return ERR_PTR(result);
>  }
> +EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
>
>  struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
>                                                          void *devdata, struct thermal_zone_device_ops *ops,
> --
> 2.34.1
>
Daniel Lezcano Aug. 10, 2022, 1:40 p.m. UTC | #2
On 10/08/2022 13:58, Rafael J. Wysocki wrote:
> On Wed, Aug 10, 2022 at 12:07 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> The function thermal_zone_device_register_with_trips() is not exported
>> for modules.
>>
>> Add the missing EXPORT_SYMBOL_GPL().
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> 
> A Fixes tag missing?

He he :) Indeed ...
Daniel Lezcano Aug. 10, 2022, 1:58 p.m. UTC | #3
On 10/08/2022 13:58, Rafael J. Wysocki wrote:
> On Wed, Aug 10, 2022 at 12:07 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> The function thermal_zone_device_register_with_trips() is not exported
>> for modules.
>>
>> Add the missing EXPORT_SYMBOL_GPL().
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> 
> A Fixes tag missing?

I've added the missing tag in the thermal/linux-next branch

https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/commit/?h=thermal/linux-next&id=78ad78d78b43538e6dcbce3fd0699f15b79cfe3f

> 
>> ---
>>   drivers/thermal/thermal_core.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
>> index b4c68410c158..10c979dce512 100644
>> --- a/drivers/thermal/thermal_core.c
>> +++ b/drivers/thermal/thermal_core.c
>> @@ -1329,6 +1329,7 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
>>          kfree(tz);
>>          return ERR_PTR(result);
>>   }
>> +EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
>>
>>   struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
>>                                                           void *devdata, struct thermal_zone_device_ops *ops,
>> --
>> 2.34.1
>>
diff mbox series

Patch

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index b4c68410c158..10c979dce512 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1329,6 +1329,7 @@  thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
 	kfree(tz);
 	return ERR_PTR(result);
 }
+EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
 
 struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
 							 void *devdata, struct thermal_zone_device_ops *ops,