| Message ID | 20220905071418.1518338-2-li.meng@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add explanation for | expand |
On 9/5/22 01:14, Meng Li wrote: > This kernel module is used for testing. It's safe to say M here. > It can also be built-in without X86_AMD_PSTATE enabled. > Currently, only tests for amd-pstate are supported. If X86_AMD_PSTATE > is set disabled, it can tell the users test can only run on amd-pstate > driver, please set X86_AMD_PSTATE enabled. > In the future, comparison tests will be added. It can set amd-pstate > disabled and set acpi-cpufreq enabled to run test cases, then compare > the test results. > > Signed-off-by: Meng Li <li.meng@amd.com> > --- > drivers/cpufreq/Kconfig.x86 | 12 +++++++----- > tools/testing/selftests/amd-pstate/amd-pstate-ut.sh | 1 + > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 > index fd1582716c58..310779b07daf 100644 > --- a/drivers/cpufreq/Kconfig.x86 > +++ b/drivers/cpufreq/Kconfig.x86 > @@ -58,11 +58,13 @@ config X86_AMD_PSTATE_UT > help > This kernel module is used for testing. It's safe to say M here. > > - It can be modprobed even without amd-pstate module. > - When the comparison test is performed, it can load other module > - like acpi-cpufreq to test cases, then compare the test results. > - When only the test for amd-pstate is performed, it can tell the > - users they loaded a wrong module like acpi-cpufreq. > + It can also be built-in without X86_AMD_PSTATE enabled. > + Currently, only tests for amd-pstate are supported. If X86_AMD_PSTATE > + is set disabled, it can tell the users test can only run on amd-pstate > + driver, please set X86_AMD_PSTATE enabled. > + In the future, comparison tests will be added. It can set amd-pstate > + disabled and set acpi-cpufreq enabled to run test cases, then compare > + the test results. > > config X86_ACPI_CPUFREQ > tristate "ACPI Processor P-States driver" > diff --git a/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh > index 273364650285..f8e82d91ffcf 100755 > --- a/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh > +++ b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh > @@ -32,6 +32,7 @@ fi > scaling_driver=$(cat /sys/devices/system/cpu/cpufreq/policy0/scaling_driver) > if [ "$scaling_driver" != "amd-pstate" ]; then > echo "$0 # Skipped: Test can only run on amd-pstate driver." > + echo "$0 # Please set X86_AMD_PSTATE enabled." > echo "$0 # Current cpufreq scaling drvier is $scaling_driver." > exit $ksft_skip > fi This patch doesn't apply on top of the previous patch series in linux-kselftest next - please rebase and resend the patch. thanks, -- Shuah
diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 index fd1582716c58..310779b07daf 100644 --- a/drivers/cpufreq/Kconfig.x86 +++ b/drivers/cpufreq/Kconfig.x86 @@ -58,11 +58,13 @@ config X86_AMD_PSTATE_UT help This kernel module is used for testing. It's safe to say M here. - It can be modprobed even without amd-pstate module. - When the comparison test is performed, it can load other module - like acpi-cpufreq to test cases, then compare the test results. - When only the test for amd-pstate is performed, it can tell the - users they loaded a wrong module like acpi-cpufreq. + It can also be built-in without X86_AMD_PSTATE enabled. + Currently, only tests for amd-pstate are supported. If X86_AMD_PSTATE + is set disabled, it can tell the users test can only run on amd-pstate + driver, please set X86_AMD_PSTATE enabled. + In the future, comparison tests will be added. It can set amd-pstate + disabled and set acpi-cpufreq enabled to run test cases, then compare + the test results. config X86_ACPI_CPUFREQ tristate "ACPI Processor P-States driver" diff --git a/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh index 273364650285..f8e82d91ffcf 100755 --- a/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh +++ b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh @@ -32,6 +32,7 @@ fi scaling_driver=$(cat /sys/devices/system/cpu/cpufreq/policy0/scaling_driver) if [ "$scaling_driver" != "amd-pstate" ]; then echo "$0 # Skipped: Test can only run on amd-pstate driver." + echo "$0 # Please set X86_AMD_PSTATE enabled." echo "$0 # Current cpufreq scaling drvier is $scaling_driver." exit $ksft_skip fi
This kernel module is used for testing. It's safe to say M here. It can also be built-in without X86_AMD_PSTATE enabled. Currently, only tests for amd-pstate are supported. If X86_AMD_PSTATE is set disabled, it can tell the users test can only run on amd-pstate driver, please set X86_AMD_PSTATE enabled. In the future, comparison tests will be added. It can set amd-pstate disabled and set acpi-cpufreq enabled to run test cases, then compare the test results. Signed-off-by: Meng Li <li.meng@amd.com> --- drivers/cpufreq/Kconfig.x86 | 12 +++++++----- tools/testing/selftests/amd-pstate/amd-pstate-ut.sh | 1 + 2 files changed, 8 insertions(+), 5 deletions(-)