| Message ID | 20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles | expand |
On 16/11/2022 11:14, Neil Armstrong wrote: > This documents the compatibles used to describe the Bandwidth Monitors > present on the SM8550 platform. Do not use "This commit/patch", so just "Document the ...." https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC > bandwidth monitoring. > > This is described this by adding "llcc" and "cpu" into the compatible One "this" too many. > strings to differentiate the BWMON IPs. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 16/11/2022 11:31, Krzysztof Kozlowski wrote: > On 16/11/2022 11:14, Neil Armstrong wrote: >> This documents the compatibles used to describe the Bandwidth Monitors >> present on the SM8550 platform. > > Do not use "This commit/patch", so just "Document the ...." > > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > >> >> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC >> bandwidth monitoring. >> >> This is described this by adding "llcc" and "cpu" into the compatible > > One "this" too many. > >> strings to differentiate the BWMON IPs. >> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks, will fix the commit message accordingly. Neil > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml index be29e0b80995..00b635662697 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml @@ -26,8 +26,13 @@ properties: - enum: - qcom,sc7280-cpu-bwmon - qcom,sdm845-bwmon + - qcom,sm8550-cpu-bwmon - const: qcom,msm8998-bwmon - const: qcom,msm8998-bwmon # BWMON v4 + - items: + - enum: + - qcom,sm8550-llcc-bwmon + - const: qcom,sc7280-llcc-bwmon - const: qcom,sc7280-llcc-bwmon # BWMON v5 - const: qcom,sdm845-llcc-bwmon # BWMON v5
This documents the compatibles used to describe the Bandwidth Monitors present on the SM8550 platform. A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC bandwidth monitoring. This is described this by adding "llcc" and "cpu" into the compatible strings to differentiate the BWMON IPs. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org> To: Bjorn Andersson <andersson@kernel.org> To: Konrad Dybcio <konrad.dybcio@somainline.org> To: Georgi Djakov <djakov@kernel.org> To: Rob Herring <robh+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org Cc: linux-pm@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 5 +++++ 1 file changed, 5 insertions(+) --- base-commit: 3c1f24109dfc4fb1a3730ed237e50183c6bb26b3 change-id: 20221114-narmstrong-sm8550-upstream-bwmon-a7c6227fab6d Best regards,