diff mbox series

[v2] dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles

Message ID 20221114-narmstrong-sm8550-upstream-bwmon-v2-0-20c555e3ba5d@linaro.org (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series [v2] dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles | expand

Commit Message

Neil Armstrong Nov. 18, 2022, 8:29 a.m. UTC 
Document the compatibles used to describe the Bandwidth Monitors
present on the SM8550 platform.

A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
bandwidth monitoring.

This is described by adding "llcc" and "cpu" into the compatible
strings to differentiate the BWMON IPs.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Georgi Djakov <djakov@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Changes in v2:
- Reworded commit message
- Added Reviewed-by from Krzysztof
- Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
---
 .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml         | 5 +++++
 1 file changed, 5 insertions(+)


---
base-commit: 3aec1f3082a7f388d04a1fa1a351aa25fd6335f0
change-id: 20221114-narmstrong-sm8550-upstream-bwmon-a7c6227fab6d

Best regards,

Comments

Neil Armstrong Jan. 9, 2023, 10:09 a.m. UTC | #1 
Hi Georgi,

On 18/11/2022 09:29, Neil Armstrong wrote:
> Document the compatibles used to describe the Bandwidth Monitors
> present on the SM8550 platform.
> 
> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
> bandwidth monitoring.
> 
> This is described by adding "llcc" and "cpu" into the compatible
> strings to differentiate the BWMON IPs.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> To: Andy Gross <agross@kernel.org>
> To: Bjorn Andersson <andersson@kernel.org>
> To: Konrad Dybcio <konrad.dybcio@somainline.org>
> To: Georgi Djakov <djakov@kernel.org>
> To: Rob Herring <robh+dt@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> Changes in v2:
> - Reworded commit message
> - Added Reviewed-by from Krzysztof
> - Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
> ---
>   .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml         | 5 +++++
>   1 file changed, 5 insertions(+)
> 

<snip>


Gentle ping,

Thanks,
Neil
Georgi Djakov Jan. 9, 2023, 11:18 a.m. UTC | #2 
Hi Neil,

On 9.01.23 12:09, Neil Armstrong wrote:
> Hi Georgi,
> 
> On 18/11/2022 09:29, Neil Armstrong wrote:
>> Document the compatibles used to describe the Bandwidth Monitors
>> present on the SM8550 platform.
>>
>> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
>> bandwidth monitoring.
>>
>> This is described by adding "llcc" and "cpu" into the compatible
>> strings to differentiate the BWMON IPs.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> To: Andy Gross <agross@kernel.org>
>> To: Bjorn Andersson <andersson@kernel.org>
>> To: Konrad Dybcio <konrad.dybcio@somainline.org>
>> To: Georgi Djakov <djakov@kernel.org>
>> To: Rob Herring <robh+dt@kernel.org>
>> Cc: linux-arm-msm@vger.kernel.org
>> Cc: linux-pm@vger.kernel.org
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> Changes in v2:
>> - Reworded commit message
>> - Added Reviewed-by from Krzysztof
>> - Link to v1: 
>> https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
>> ---
>>   .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml         | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
> 
> <snip>
> 
> 
> Gentle ping,

Thanks for the patch! Could you please rebase and resend?

BR,
Georgi
Neil Armstrong Jan. 9, 2023, 12:09 p.m. UTC | #3 
On 09/01/2023 12:18, Georgi Djakov wrote:
> Hi Neil,
> 
> On 9.01.23 12:09, Neil Armstrong wrote:
>> Hi Georgi,
>>
>> On 18/11/2022 09:29, Neil Armstrong wrote:
>>> Document the compatibles used to describe the Bandwidth Monitors
>>> present on the SM8550 platform.
>>>
>>> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
>>> bandwidth monitoring.
>>>
>>> This is described by adding "llcc" and "cpu" into the compatible
>>> strings to differentiate the BWMON IPs.
>>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> To: Andy Gross <agross@kernel.org>
>>> To: Bjorn Andersson <andersson@kernel.org>
>>> To: Konrad Dybcio <konrad.dybcio@somainline.org>
>>> To: Georgi Djakov <djakov@kernel.org>
>>> To: Rob Herring <robh+dt@kernel.org>
>>> Cc: linux-arm-msm@vger.kernel.org
>>> Cc: linux-pm@vger.kernel.org
>>> Cc: devicetree@vger.kernel.org
>>> Cc: linux-kernel@vger.kernel.org
>>> ---
>>> Changes in v2:
>>> - Reworded commit message
>>> - Added Reviewed-by from Krzysztof
>>> - Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
>>> ---
>>>   .../devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml         | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>
>> <snip>
>>
>>
>> Gentle ping,
> 
> Thanks for the patch! Could you please rebase and resend?

Sure

Thanks,
Neil

> 
> BR,
> Georgi
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
index be29e0b80995..00b635662697 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
@@ -26,8 +26,13 @@  properties:
           - enum:
               - qcom,sc7280-cpu-bwmon
               - qcom,sdm845-bwmon
+              - qcom,sm8550-cpu-bwmon
           - const: qcom,msm8998-bwmon
       - const: qcom,msm8998-bwmon       # BWMON v4
+      - items:
+          - enum:
+              - qcom,sm8550-llcc-bwmon
+          - const: qcom,sc7280-llcc-bwmon
       - const: qcom,sc7280-llcc-bwmon   # BWMON v5
       - const: qcom,sdm845-llcc-bwmon   # BWMON v5