| Message ID | 20230206122018.3601419-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [-next,v2] power: supply: rt9471: fix using wrong ce_gpio in rt9471_probe() | expand |
Hi, On Mon, Feb 06, 2023 at 08:20:18PM +0800, Yang Yingliang wrote: > Pass the correct 'ce_gpio' to IS_ERR(), and remove the ce_gpio in > chip data, make it all by SW control only, not to control by HW pin. > > Fixes: 4a1a5f6781d8 ("power: supply: rt9471: Add Richtek RT9471 charger driver") > Reviewed-by: ChiYuan Huang <cy_huang@richtek.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- Thanks, queued. -- Sebastian > v1 -> v2: > Remove the ce_gpio in chip data. > --- > drivers/power/supply/rt9471.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/power/supply/rt9471.c b/drivers/power/supply/rt9471.c > index 5d3cf375ad5c..1ea40876494b 100644 > --- a/drivers/power/supply/rt9471.c > +++ b/drivers/power/supply/rt9471.c > @@ -141,7 +141,6 @@ enum { > > struct rt9471_chip { > struct device *dev; > - struct gpio_desc *ce_gpio; > struct regmap *regmap; > struct regmap_field *rm_fields[F_MAX_FIELDS]; > struct regmap_irq_chip_data *irq_chip_data; > @@ -851,7 +850,7 @@ static int rt9471_probe(struct i2c_client *i2c) > > /* Default pull charge enable gpio to make 'CHG_EN' by SW control only */ > ce_gpio = devm_gpiod_get_optional(dev, "charge-enable", GPIOD_OUT_HIGH); > - if (IS_ERR(chip->ce_gpio)) > + if (IS_ERR(ce_gpio)) > return dev_err_probe(dev, PTR_ERR(ce_gpio), > "Failed to config charge enable gpio\n"); > > -- > 2.25.1 >
diff --git a/drivers/power/supply/rt9471.c b/drivers/power/supply/rt9471.c index 5d3cf375ad5c..1ea40876494b 100644 --- a/drivers/power/supply/rt9471.c +++ b/drivers/power/supply/rt9471.c @@ -141,7 +141,6 @@ enum { struct rt9471_chip { struct device *dev; - struct gpio_desc *ce_gpio; struct regmap *regmap; struct regmap_field *rm_fields[F_MAX_FIELDS]; struct regmap_irq_chip_data *irq_chip_data; @@ -851,7 +850,7 @@ static int rt9471_probe(struct i2c_client *i2c) /* Default pull charge enable gpio to make 'CHG_EN' by SW control only */ ce_gpio = devm_gpiod_get_optional(dev, "charge-enable", GPIOD_OUT_HIGH); - if (IS_ERR(chip->ce_gpio)) + if (IS_ERR(ce_gpio)) return dev_err_probe(dev, PTR_ERR(ce_gpio), "Failed to config charge enable gpio\n");
Pass the correct 'ce_gpio' to IS_ERR(), and remove the ce_gpio in chip data, make it all by SW control only, not to control by HW pin. Fixes: 4a1a5f6781d8 ("power: supply: rt9471: Add Richtek RT9471 charger driver") Reviewed-by: ChiYuan Huang <cy_huang@richtek.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- v1 -> v2: Remove the ce_gpio in chip data. --- drivers/power/supply/rt9471.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)