From patchwork Thu Feb 16 10:51:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13142935 X-Patchwork-Delegate: viresh.linux@gmail.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5926CC61DA4 for ; Thu, 16 Feb 2023 10:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230208AbjBPKvw (ORCPT ); Thu, 16 Feb 2023 05:51:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbjBPKvq (ORCPT ); Thu, 16 Feb 2023 05:51:46 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9B69552BF for ; Thu, 16 Feb 2023 02:51:45 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id bp15so2211399lfb.13 for ; Thu, 16 Feb 2023 02:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2skU52xYnO88MOQQej9qwovXl4uCZ1SRLC9dCn0g3F0=; b=w35RlwJY2q7CwCKYoYX3G+msGQGtbKbMqI6BWxsXKZOGy3eVZykH2f3iwb9JWOyPlU l7ilUC6Jks3WOTF9IbdFRzMIEEcY2jVFKGQAk+RWcOwn7aLdJZw0YKVnqNH5US6kYoiw pQi/lIlaOv0B+Vf3gHz6ygAF3nUndhuevp6uFIpys9g9sl25ejx6YVrFNwRLUgo0w6vW d4Xleh7jeFpITMQzYisytdhcpOMInRDlX224/9e0umOrXUJ54Xn0rleYfuYLPj0A1BNC 28IB9om7hBCuK6ZVuVwPVf8+LlvVRTVpxnRed0rDERzNniYNzQyGNKUCsidke5yEwi1s w5pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2skU52xYnO88MOQQej9qwovXl4uCZ1SRLC9dCn0g3F0=; b=b+daAfRs6AcrjMMD3U66tFzlBGDp955zDB9mOFoOWWQhcoCJbHs8D/Z0WESeYGvuel 4z03E748C2b65nvHpLAJIxc3hxM1NgD1e5hRD1vwTnabklI3NCpAYNqCF8VfnTuc+cCE 3uZlWwFcDc6XN6ltKLclco4gNKe9Hf47Yu63mo1HbkcISVNqg4YnQxvBc5DNzTLFK9T2 ZlyxZQzdTn7pvIGeoT26S6AliQHvL8fKWvQSVJ1yHwR3SPZMBHIz3Y3UUOTAQx4jVroh 3vDrjAmIf4o2nZPqlfVYbzbSeNLUFTfneYV4TZlLHf4jgX1lh3DqMXJU1YK3B/G8Eijt eVCA== X-Gm-Message-State: AO0yUKUiD+AZp5KFXxTj3XXEglqJSC39JMp4QPbfmppQTysDqGnNxdYq OrBHaDfPLMgeDuC4QB3LC1LeSw== X-Google-Smtp-Source: AK7set/Z1Pba3KSZc9/U8jKXhZy2f7jCxjKs2RBVTce+cckvI4cRhoYJ9ifcwsZbJO5kJy/uehXRqg== X-Received: by 2002:ac2:4855:0:b0:4d6:d0c5:5c57 with SMTP id 21-20020ac24855000000b004d6d0c55c57mr1606852lfy.62.1676544704074; Thu, 16 Feb 2023 02:51:44 -0800 (PST) Received: from localhost.localdomain (abxh117.neoplus.adsl.tpnet.pl. [83.9.1.117]) by smtp.gmail.com with ESMTPSA id m11-20020a19520b000000b004cb34b81150sm249903lfb.282.2023.02.16.02.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 02:51:43 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] cpufreq: qcom-hw: Simplify counting frequency domains Date: Thu, 16 Feb 2023 11:51:40 +0100 Message-Id: <20230216105140.3938749-1-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org For quite some time, this driver has been performing some quite low-level DT operations. Simplify that using platform_get_resource. Signed-off-by: Konrad Dybcio Reviewed-by: Bjorn Andersson --- v1 -> v2: - remove stray newline near probe return - s/doing performing/performing/ v1: https://lore.kernel.org/linux-arm-msm/20230216102956.3933639-1-konrad.dybcio@linaro.org/T/#u drivers/cpufreq/qcom-cpufreq-hw.c | 29 ++++++----------------------- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index 2f581d2d617d..575a4461c25a 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -29,6 +29,8 @@ #define GT_IRQ_STATUS BIT(2) +#define MAX_FREQ_DOMAINS 3 + struct qcom_cpufreq_soc_data { u32 reg_enable; u32 reg_domain_state; @@ -651,10 +653,9 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev) { struct clk_hw_onecell_data *clk_data; struct device *dev = &pdev->dev; - struct device_node *soc_node; struct device *cpu_dev; struct clk *clk; - int ret, i, num_domains, reg_sz; + int ret, i, num_domains; clk = clk_get(dev, "xo"); if (IS_ERR(clk)) @@ -681,24 +682,9 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev) if (ret) return ret; - /* Allocate qcom_cpufreq_data based on the available frequency domains in DT */ - soc_node = of_get_parent(dev->of_node); - if (!soc_node) - return -EINVAL; - - ret = of_property_read_u32(soc_node, "#address-cells", ®_sz); - if (ret) - goto of_exit; - - ret = of_property_read_u32(soc_node, "#size-cells", &i); - if (ret) - goto of_exit; - - reg_sz += i; - - num_domains = of_property_count_elems_of_size(dev->of_node, "reg", sizeof(u32) * reg_sz); - if (num_domains <= 0) - return num_domains; + for (num_domains = 0; num_domains < MAX_FREQ_DOMAINS; num_domains++) + if (!platform_get_resource(pdev, IORESOURCE_MEM, num_domains)) + break; qcom_cpufreq.data = devm_kzalloc(dev, sizeof(struct qcom_cpufreq_data) * num_domains, GFP_KERNEL); @@ -762,9 +748,6 @@ static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev) else dev_dbg(dev, "QCOM CPUFreq HW driver initialized\n"); -of_exit: - of_node_put(soc_node); - return ret; }