| Message ID | 20230309092821.1590586-2-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | [v2,1/2] thermal/drivers/imx: Remove get_trip_temp ops | expand |
On Thu, Mar 9, 2023 at 6:28 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > The thermal framework provides an API to get the trip related to a > trip point id. We want to consolidate the generic trip points code, > thus preventing the different drivers to deal with the trip points > after they registered them. > > The set_trip_temp ops will be changed regarding the above changes but > first we need to rework a bit the different implementation in the > drivers. > > The goal is to prevent using the trip id but use a trip point passed > as parameter which will contain all the needed information. > > As we don't have the trip point passed as parameter yet, we get the > trip point using the generic trip thermal framewrok APIs and use it to > take exactly the same decisions. > > The difference with this change and the previous code is from where we > get the thermal trip point (which is the same). > > No functional change intended. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > V2: > - Remove extra tab inserted in the previous version Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c index 69ed482167f7..13c56e45cdbc 100644 --- a/drivers/thermal/imx_thermal.c +++ b/drivers/thermal/imx_thermal.c @@ -330,26 +330,29 @@ static int imx_change_mode(struct thermal_zone_device *tz, return 0; } -static int imx_set_trip_temp(struct thermal_zone_device *tz, int trip, +static int imx_set_trip_temp(struct thermal_zone_device *tz, int trip_id, int temp) { struct imx_thermal_data *data = thermal_zone_device_priv(tz); + struct thermal_trip trip; int ret; ret = pm_runtime_resume_and_get(data->dev); if (ret < 0) return ret; + ret = __thermal_zone_get_trip(tz, trip_id, &trip); + if (ret) + return ret; + /* do not allow changing critical threshold */ - if (trip == IMX_TRIP_CRITICAL) + if (trip.type == THERMAL_TRIP_CRITICAL) return -EPERM; /* do not allow passive to be set higher than critical */ if (temp < 0 || temp > trips[IMX_TRIP_CRITICAL].temperature) return -EINVAL; - trips[IMX_TRIP_PASSIVE].temperature = temp; - imx_set_alarm_temp(data, temp); pm_runtime_put(data->dev);
The thermal framework provides an API to get the trip related to a trip point id. We want to consolidate the generic trip points code, thus preventing the different drivers to deal with the trip points after they registered them. The set_trip_temp ops will be changed regarding the above changes but first we need to rework a bit the different implementation in the drivers. The goal is to prevent using the trip id but use a trip point passed as parameter which will contain all the needed information. As we don't have the trip point passed as parameter yet, we get the trip point using the generic trip thermal framewrok APIs and use it to take exactly the same decisions. The difference with this change and the previous code is from where we get the thermal trip point (which is the same). No functional change intended. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- V2: - Remove extra tab inserted in the previous version --- drivers/thermal/imx_thermal.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)