| Message ID | 20230329-dt-cpu-header-cleanups-v1-15-581e2605fe47@kernel.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | DT header disentangling, part 1 | expand |
Dne sreda, 29. marec 2023 ob 17:52:12 CEST je Rob Herring napisal(a): > Removing the include of cpu.h from of_device.h causes an error: > > drivers/cpufreq/sun50i-cpufreq-nvmem.c:42:19: error: implicit declaration of > function ‘get_cpu_device’; did you mean ‘get_device’? > [-Werror=implicit-function-declaration] > > As of_device.h is not otherwise needed, it can be replaced with of.h > (also implicitly included). > > Signed-off-by: Rob Herring <robh@kernel.org> > --- Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej
On 29-03-23, 10:52, Rob Herring wrote: > Removing the include of cpu.h from of_device.h causes an error: > > drivers/cpufreq/sun50i-cpufreq-nvmem.c:42:19: error: implicit declaration of function ‘get_cpu_device’; did you mean ‘get_device’? [-Werror=implicit-function-declaration] > > As of_device.h is not otherwise needed, it can be replaced with of.h > (also implicitly included). > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Please ack and I will take the series via the DT tree. > --- > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c > index 1583a370da39..4321d7bbe769 100644 > --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c > +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c > @@ -10,9 +10,10 @@ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > +#include <linux/cpu.h> > #include <linux/module.h> > #include <linux/nvmem-consumer.h> > -#include <linux/of_device.h> > +#include <linux/of.h> > #include <linux/platform_device.h> > #include <linux/pm_opp.h> > #include <linux/slab.h> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c index 1583a370da39..4321d7bbe769 100644 --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c @@ -10,9 +10,10 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include <linux/cpu.h> #include <linux/module.h> #include <linux/nvmem-consumer.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_opp.h> #include <linux/slab.h>
Removing the include of cpu.h from of_device.h causes an error: drivers/cpufreq/sun50i-cpufreq-nvmem.c:42:19: error: implicit declaration of function ‘get_cpu_device’; did you mean ‘get_device’? [-Werror=implicit-function-declaration] As of_device.h is not otherwise needed, it can be replaced with of.h (also implicitly included). Signed-off-by: Rob Herring <robh@kernel.org> --- Please ack and I will take the series via the DT tree. --- drivers/cpufreq/sun50i-cpufreq-nvmem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)