| Message ID | 20230702175045.122041-5-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers | show |
| Series | ARM: qcom: msm8960: support CPU frequency scaling | expand |
On 2.07.2023 19:50, Dmitry Baryshkov wrote: > Add additional constraints to the CPUfreq-related regulators, it is > better be safe than sorry there. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- I'm squinting quite hard at https://github.com/LineageOS/sony-kernel-msm8960/blob/jb-dev/arch/arm/mach-msm/acpuclock-8960.c but I can't figure out where these min values came from Konrad > arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts > index 414881d34c60..cba0d1e460a1 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts > +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts > @@ -131,7 +131,7 @@ pm8921_s2: s2 { > }; > > pm8921_s3: s3 { > - regulator-min-microvolt = <500000>; > + regulator-min-microvolt = <950000>; > regulator-max-microvolt = <1150000>; > qcom,switch-mode-frequency = <4800000>; > bias-pull-down; > @@ -287,7 +287,7 @@ pm8921_l23: l23 { > }; > > pm8921_l24: l24 { > - regulator-min-microvolt = <750000>; > + regulator-min-microvolt = <1050000>; > regulator-max-microvolt = <1150000>; > bias-pull-down; > };
On Tue, 4 Jul 2023 at 16:03, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 2.07.2023 19:50, Dmitry Baryshkov wrote: > > Add additional constraints to the CPUfreq-related regulators, it is > > better be safe than sorry there. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > I'm squinting quite hard at > > https://github.com/LineageOS/sony-kernel-msm8960/blob/jb-dev/arch/arm/mach-msm/acpuclock-8960.c > > but I can't figure out where these min values came from These should be the minimum values for vdd_min and vdd_dig in l2_freq_tbl_8960_kraitv2 (v1 is unsupported in mainline). See below, > > Konrad > > arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts > > index 414881d34c60..cba0d1e460a1 100644 > > --- a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts > > +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts > > @@ -131,7 +131,7 @@ pm8921_s2: s2 { > > }; > > > > pm8921_s3: s3 { > > - regulator-min-microvolt = <500000>; > > + regulator-min-microvolt = <950000>; And this is obviously a c&p from 8064. This should be 1050000. > > regulator-max-microvolt = <1150000>; > > qcom,switch-mode-frequency = <4800000>; > > bias-pull-down; > > @@ -287,7 +287,7 @@ pm8921_l23: l23 { > > }; > > > > pm8921_l24: l24 { > > - regulator-min-microvolt = <750000>; > > + regulator-min-microvolt = <1050000>; > > regulator-max-microvolt = <1150000>; > > bias-pull-down; > > };
On 4.07.2023 15:34, Dmitry Baryshkov wrote: > On Tue, 4 Jul 2023 at 16:03, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> On 2.07.2023 19:50, Dmitry Baryshkov wrote: >>> Add additional constraints to the CPUfreq-related regulators, it is >>> better be safe than sorry there. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >> I'm squinting quite hard at >> >> https://github.com/LineageOS/sony-kernel-msm8960/blob/jb-dev/arch/arm/mach-msm/acpuclock-8960.c >> >> but I can't figure out where these min values came from > > These should be the minimum values for vdd_min and vdd_dig in > l2_freq_tbl_8960_kraitv2 (v1 is unsupported in mainline). > See below, > >> >> Konrad >>> arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts >>> index 414881d34c60..cba0d1e460a1 100644 >>> --- a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts >>> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts >>> @@ -131,7 +131,7 @@ pm8921_s2: s2 { >>> }; >>> >>> pm8921_s3: s3 { >>> - regulator-min-microvolt = <500000>; >>> + regulator-min-microvolt = <950000>; > > And this is obviously a c&p from 8064. This should be 1050000. Okay, please remember to fix all other boards from this patchset too. Konrad > >>> regulator-max-microvolt = <1150000>; >>> qcom,switch-mode-frequency = <4800000>; >>> bias-pull-down; >>> @@ -287,7 +287,7 @@ pm8921_l23: l23 { >>> }; >>> >>> pm8921_l24: l24 { >>> - regulator-min-microvolt = <750000>; >>> + regulator-min-microvolt = <1050000>; >>> regulator-max-microvolt = <1150000>; >>> bias-pull-down; >>> }; > > >
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts index 414881d34c60..cba0d1e460a1 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts @@ -131,7 +131,7 @@ pm8921_s2: s2 { }; pm8921_s3: s3 { - regulator-min-microvolt = <500000>; + regulator-min-microvolt = <950000>; regulator-max-microvolt = <1150000>; qcom,switch-mode-frequency = <4800000>; bias-pull-down; @@ -287,7 +287,7 @@ pm8921_l23: l23 { }; pm8921_l24: l24 { - regulator-min-microvolt = <750000>; + regulator-min-microvolt = <1050000>; regulator-max-microvolt = <1150000>; bias-pull-down; };
Add additional constraints to the CPUfreq-related regulators, it is better be safe than sorry there. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)