| Message ID | 20230731110012.2913742-2-jagan@edgeble.ai (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [01/14] genpd: rockchip: Add PD_VO entry for rv1126 | expand |
Am Montag, 31. Juli 2023, 12:59:59 CEST schrieb Jagan Teki: > PD_VO power-domain entry in RV1126 are connected to > - BIU_VO > - VOP > - RGA > - IEP > - DSIHOST > > Add an entry for it. > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> Reviewed-by: Heiko Stuebner <heiko@sntech.de> @Ulf: now that we have a genpd subsystem, I assume you're going to pick up this patch, right? Thanks Heiko > --- > Cc: linux-pm@vger.kernel.org > Cc: Ulf Hansson <ulf.hansson@linaro.org> > > drivers/genpd/rockchip/pm-domains.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/genpd/rockchip/pm-domains.c b/drivers/genpd/rockchip/pm-domains.c > index e3de49e671dc..d5d3ecb38283 100644 > --- a/drivers/genpd/rockchip/pm-domains.c > +++ b/drivers/genpd/rockchip/pm-domains.c > @@ -976,6 +976,7 @@ static const struct rockchip_domain_info px30_pm_domains[] = { > static const struct rockchip_domain_info rv1126_pm_domains[] = { > [RV1126_PD_VEPU] = DOMAIN_RV1126("vepu", BIT(2), BIT(9), BIT(9), false), > [RV1126_PD_VI] = DOMAIN_RV1126("vi", BIT(4), BIT(6), BIT(6), false), > + [RV1126_PD_VO] = DOMAIN_RV1126("vo", BIT(5), BIT(7), BIT(7), false), > [RV1126_PD_ISPP] = DOMAIN_RV1126("ispp", BIT(1), BIT(8), BIT(8), false), > [RV1126_PD_VDPU] = DOMAIN_RV1126("vdpu", BIT(3), BIT(10), BIT(10), false), > [RV1126_PD_NVM] = DOMAIN_RV1126("nvm", BIT(7), BIT(11), BIT(11), false), >
Am Montag, 31. Juli 2023, 22:48:45 CEST schrieb Heiko Stübner: > Am Montag, 31. Juli 2023, 12:59:59 CEST schrieb Jagan Teki: > > PD_VO power-domain entry in RV1126 are connected to > > - BIU_VO > > - VOP > > - RGA > > - IEP > > - DSIHOST > > > > Add an entry for it. > > > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > @Ulf: now that we have a genpd subsystem, I assume you're going > to pick up this patch, right? Looking at other soc trees, it looks like genpd changes right now are often still going through these ... so I've gone forward, merged the genpd shared tag and applied this patch on top in my rockchip drivers branch.
On Sat, 12 Aug 2023 at 14:57, Heiko Stübner <heiko@sntech.de> wrote: > > Am Montag, 31. Juli 2023, 22:48:45 CEST schrieb Heiko Stübner: > > Am Montag, 31. Juli 2023, 12:59:59 CEST schrieb Jagan Teki: > > > PD_VO power-domain entry in RV1126 are connected to > > > - BIU_VO > > > - VOP > > > - RGA > > > - IEP > > > - DSIHOST > > > > > > Add an entry for it. > > > > > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > > > @Ulf: now that we have a genpd subsystem, I assume you're going > > to pick up this patch, right? Yes, that's the intent. At least after v6.6-rc1. > > Looking at other soc trees, it looks like genpd changes right now are > often still going through these ... so I've gone forward, merged the > genpd shared tag and applied this patch on top in my rockchip drivers > branch. That's fine. We are in an intermediate phase, so things are being queued both via the soc trees and the genpd tree. I am planning to send a pull-request to Linus for v6.6-rc1 to make sure the delta that hasn't already been pulled by Arnd gets included too. If you merge the immutable branch, you should have the necessary parts. Kind regards Uffe
diff --git a/drivers/genpd/rockchip/pm-domains.c b/drivers/genpd/rockchip/pm-domains.c index e3de49e671dc..d5d3ecb38283 100644 --- a/drivers/genpd/rockchip/pm-domains.c +++ b/drivers/genpd/rockchip/pm-domains.c @@ -976,6 +976,7 @@ static const struct rockchip_domain_info px30_pm_domains[] = { static const struct rockchip_domain_info rv1126_pm_domains[] = { [RV1126_PD_VEPU] = DOMAIN_RV1126("vepu", BIT(2), BIT(9), BIT(9), false), [RV1126_PD_VI] = DOMAIN_RV1126("vi", BIT(4), BIT(6), BIT(6), false), + [RV1126_PD_VO] = DOMAIN_RV1126("vo", BIT(5), BIT(7), BIT(7), false), [RV1126_PD_ISPP] = DOMAIN_RV1126("ispp", BIT(1), BIT(8), BIT(8), false), [RV1126_PD_VDPU] = DOMAIN_RV1126("vdpu", BIT(3), BIT(10), BIT(10), false), [RV1126_PD_NVM] = DOMAIN_RV1126("nvm", BIT(7), BIT(11), BIT(11), false),
PD_VO power-domain entry in RV1126 are connected to - BIU_VO - VOP - RGA - IEP - DSIHOST Add an entry for it. Signed-off-by: Jagan Teki <jagan@edgeble.ai> --- Cc: linux-pm@vger.kernel.org Cc: Ulf Hansson <ulf.hansson@linaro.org> drivers/genpd/rockchip/pm-domains.c | 1 + 1 file changed, 1 insertion(+)