| Message ID | 20231018061714.3553817-27-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Chanwoo Choi |
| Headers | show |
| Series | Add perf support to the rockchip-dfi driver | expand |
On Wed, 18 Oct 2023 at 11:47, Sascha Hauer <s.hauer@pengutronix.de> wrote: > > The DFI unit can be used to measure DRAM utilization using perf. Add the > node to the device tree. The DFI needs a rockchip,pmu phandle to the pmu > containing registers for SDRAM configuration details. This is added in > this patch as well. > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > > Notes: > Changes since v4: > - new patch > > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > index 5544f66c6ff41..e693a341f6f27 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > @@ -443,6 +443,11 @@ usb_host1_ohci: usb@fc8c0000 { > status = "disabled"; > }; > > + pmu1grf: syscon@fd58a000 { > + compatible = "rockchip,rk3588-pmugrf", "syscon", "simple-mfd"; > + reg = <0x0 0xfd58a000 0x0 0x10000>; > + }; > + > sys_grf: syscon@fd58c000 { > compatible = "rockchip,rk3588-sys-grf", "syscon"; > reg = <0x0 0xfd58c000 0x0 0x1000>; > @@ -1329,6 +1334,17 @@ pcie2x1l2_intc: legacy-interrupt-controller { > }; > }; > > + dfi: dfi@fe060000 { > + reg = <0x00 0xfe060000 0x00 0x10000>; > + compatible = "rockchip,rk3588-dfi"; > + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH 0>; > + interrupt-names = "ch0", "ch1", "ch2", "ch3"; Look like the names never documented and nor supported explicitly in the driver. Do we have any patch for fixing it in the mailing-list? arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dtb: dfi@fe060000: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/devfreq/event/rockchip,dfi.yaml# Jagan.
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index 5544f66c6ff41..e693a341f6f27 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi @@ -443,6 +443,11 @@ usb_host1_ohci: usb@fc8c0000 { status = "disabled"; }; + pmu1grf: syscon@fd58a000 { + compatible = "rockchip,rk3588-pmugrf", "syscon", "simple-mfd"; + reg = <0x0 0xfd58a000 0x0 0x10000>; + }; + sys_grf: syscon@fd58c000 { compatible = "rockchip,rk3588-sys-grf", "syscon"; reg = <0x0 0xfd58c000 0x0 0x1000>; @@ -1329,6 +1334,17 @@ pcie2x1l2_intc: legacy-interrupt-controller { }; }; + dfi: dfi@fe060000 { + reg = <0x00 0xfe060000 0x00 0x10000>; + compatible = "rockchip,rk3588-dfi"; + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH 0>; + interrupt-names = "ch0", "ch1", "ch2", "ch3"; + rockchip,pmu = <&pmu1grf>; + }; + gmac1: ethernet@fe1c0000 { compatible = "rockchip,rk3588-gmac", "snps,dwmac-4.20a"; reg = <0x0 0xfe1c0000 0x0 0x10000>;