diff mbox series

thermal: qoriq: remove redundant TMTMIR_DEFAULT

Message ID 20240313124117.3224601-1-f.suligoi@asem.it (mailing list archive)
State New
Delegated to: Daniel Lezcano
Headers show
Series thermal: qoriq: remove redundant TMTMIR_DEFAULT | expand

Commit Message

Flavio Suligoi March 13, 2024, 12:41 p.m. UTC
The definition of TMTMIR_DEFAULT is repeated two times in the code.
The first time is useless.
It makes more sense to leave this definition after the correspondent
REGS_TMTMIR register definition:

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
---
 drivers/thermal/qoriq_thermal.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Flavio Suligoi March 13, 2024, 1:45 p.m. UTC | #1
Hi all,

...
> The definition of TMTMIR_DEFAULT is repeated two times in the code.
> The first time is useless.
> It makes more sense to leave this definition after the correspondent
> REGS_TMTMIR register definition:
> 
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>

there are also other double macro definitions, such as:

TMR_DISABLE
TMR_ME
TMR_ALPF
TIER_DISABLE

Would you like me to put some order?

regards,
Flavio
diff mbox series

Patch

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index ccc2eea7f9f5..c29ed179c12d 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -20,7 +20,6 @@ 
 #define TMR_ME			0x80000000
 #define TMR_ALPF		0x0c000000
 #define TMR_ALPF_V2		0x03000000
-#define TMTMIR_DEFAULT	0x0000000f
 #define TIER_DISABLE	0x0
 #define TEUMR0_V2		0x51009c00
 #define TMSARA_V2		0xe