diff mbox series

cpupower: Remove absent 'v' parameter from monitor man page

Message ID 20240618-change-mon-format-v1-1-efa263a8e286@gmail.com (mailing list archive)
State Superseded, archived
Headers show
Series cpupower: Remove absent 'v' parameter from monitor man page | expand

Commit Message

Roman Storozhenko June 18, 2024, 7:21 p.m. UTC
Remove not supported '-v' parameter from the cpupower's 'monitor'
command description.

Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
There is a '-v' parameter described in cpupower's 'monitor' command man
page. It isn't supported at the moment, and perhaps has never been
supported. When I run the monitor with this parameter I get the
following:

$ sudo LD_LIBRARY_PATH=lib64/ bin/cpupower monitor -v
monitor: invalid option -- 'v'
invalid or unknown argument
$ sudo LD_LIBRARY_PATH=lib64/ bin/cpupower monitor -V
monitor: invalid option -- 'V'
invalid or unknown argument
---
 tools/power/cpupower/man/cpupower-monitor.1 | 5 -----
 1 file changed, 5 deletions(-)


---
base-commit: 0c52056d9f77508cb6d4d68d3fc91c6c08ec71af
change-id: 20240618-change-mon-format-30015761c58e

Best regards,

Comments

Shuah Khan June 18, 2024, 8:22 p.m. UTC | #1
On 6/18/24 13:21, Roman Storozhenko wrote:
> Remove not supported '-v' parameter from the cpupower's 'monitor'
> command description.
> 

Nice find.

> Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> ---
> There is a '-v' parameter described in cpupower's 'monitor' command man
> page. It isn't supported at the moment, and perhaps has never been
> supported. When I run the monitor with this parameter I get the
> following:
> 
> $ sudo LD_LIBRARY_PATH=lib64/ bin/cpupower monitor -v
> monitor: invalid option -- 'v'
> invalid or unknown argument
> $ sudo LD_LIBRARY_PATH=lib64/ bin/cpupower monitor -V
> monitor: invalid option -- 'V'
> invalid or unknown argument

You are burying important information in throw away text. Please
add all of the above text to commit log and send me v2.

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/tools/power/cpupower/man/cpupower-monitor.1 b/tools/power/cpupower/man/cpupower-monitor.1
index 8ee737eefa5c..991f931cfc38 100644
--- a/tools/power/cpupower/man/cpupower-monitor.1
+++ b/tools/power/cpupower/man/cpupower-monitor.1
@@ -81,11 +81,6 @@  Measure idle and frequency characteristics of an arbitrary command/workload.
 The executable \fBcommand\fP is forked and upon its exit, statistics gathered since it was
 forked are displayed.
 .RE
-.PP
-\-v
-.RS 4
-Increase verbosity if the binary was compiled with the DEBUG option set.
-.RE
 
 .SH MONITOR DESCRIPTIONS
 .SS "Idle_Stats"