| Message ID | 20241024030442.119506-2-zhangzekun11@huawei.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | Some cleanup and fix the missing of_node_put() | expand |
Hi, On Oct 24, 2024 at 11:04:41 +0800, Zhang Zekun wrote: > of_parse_phandle_with_args() needs to call of_node_put() to decrement > the refcount of args.np. So, Add the missing of_node_put() in the loop. Seems better worded now, thanks. Reviewed-by: Dhruva Gole <d-gole@ti.com> > > Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one") > Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> > --- > drivers/pmdomain/ti/ti_sci_pm_domains.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c > index 1510d5ddae3d..0df3eb7ff09a 100644 > --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c > +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c > @@ -161,6 +161,7 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev) > break; > > if (args.args_count >= 1 && args.np == dev->of_node) { > + of_node_put(args.np); > if (args.args[0] > max_id) { > max_id = args.args[0]; > } else { > @@ -192,7 +193,10 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev) > pm_genpd_init(&pd->pd, NULL, true); > > list_add(&pd->node, &pd_provider->pd_list); > + } else { > + of_node_put(args.np); > } > + Avoid irrelevant changes.. > index++; > } > } > -- > 2.17.1 >
diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c index 1510d5ddae3d..0df3eb7ff09a 100644 --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c @@ -161,6 +161,7 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev) break; if (args.args_count >= 1 && args.np == dev->of_node) { + of_node_put(args.np); if (args.args[0] > max_id) { max_id = args.args[0]; } else { @@ -192,7 +193,10 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev) pm_genpd_init(&pd->pd, NULL, true); list_add(&pd->node, &pd_provider->pd_list); + } else { + of_node_put(args.np); } + index++; } }
of_parse_phandle_with_args() needs to call of_node_put() to decrement the refcount of args.np. So, Add the missing of_node_put() in the loop. Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one") Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> --- drivers/pmdomain/ti/ti_sci_pm_domains.c | 4 ++++ 1 file changed, 4 insertions(+)