diff mbox series

[v8,1/7] dt-bindings: reset: syscon-reboot: Add reg property

Message ID 20241031200350.274945-2-chris.packham@alliedtelesis.co.nz (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series RTL9300 support for reboot and i2c | expand

Commit Message

Chris Packham Oct. 31, 2024, 8:03 p.m. UTC 
The syscon-reboot binding used 'offset' for historical reasons. Having a
reg property is appropriate when these nodes are children of a MMIO bus.
Add a reg property and modify the constraints so that one of 'reg' or
'offset' is expected.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

Notes:
    Changes in v8:
    - None. This has been applied to by Sebastian, I've just kept it in the
      series so that others can see the complete picutre
    Changes in v7:
    - None. This has been applied to by Sebastian, I've just kept it in the
      series so that others can see the complete picutre
    Changes in v6:
    - Add r-by from Krzysztof
    Changes in v5:
    - New, suggested by Krzysztof

 .../bindings/power/reset/syscon-reboot.yaml           | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Nov. 1, 2024, 7:12 a.m. UTC | #1 
On Fri, Nov 01, 2024 at 09:03:44AM +1300, Chris Packham wrote:
> The syscon-reboot binding used 'offset' for historical reasons. Having a
> reg property is appropriate when these nodes are children of a MMIO bus.
> Add a reg property and modify the constraints so that one of 'reg' or
> 'offset' is expected.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> 
> Notes:
>     Changes in v8:
>     - None. This has been applied to by Sebastian, I've just kept it in the
>       series so that others can see the complete picutre

No, this only creates unnecessary review / traffic and might lead to
duplicated patches.

Provide link to commit if you want to give a reference. *Never* send
already applied patches.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
index 75061124d9a8..19d3093e6cd2 100644
--- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
+++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml
@@ -31,6 +31,10 @@  properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: Offset in the register map for the reboot register (in bytes).
 
+  reg:
+    maxItems: 1
+    description: Base address and size for the reboot register.
+
   regmap:
     $ref: /schemas/types.yaml#/definitions/phandle
     deprecated: true
@@ -45,9 +49,14 @@  properties:
   priority:
     default: 192
 
+oneOf:
+  - required:
+      - offset
+  - required:
+      - reg
+
 required:
   - compatible
-  - offset
 
 additionalProperties: false