| Message ID | 20241122-extend_power_limit-v1-2-a3ecd87afa76@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Extend the cros_usbpd-charger to make it a passive thermal cooling device | expand |
On Fri, Nov 22, 2024 at 11:47:22AM +0800, Sung-Chi Li wrote: > The cros_ec supports limiting the input current to act as a passive > thermal cooling device. Add the property '#cooling-cells' bindings, such > that thermal framework can recognize cros_ec as a valid thermal cooling > device. > > Signed-off-by: Sung-Chi Li <lschyi@chromium.org> > --- > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index aac8819bd00b..2b6f098057af 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -96,6 +96,9 @@ properties: > '#gpio-cells': > const: 2 > > + '#cooling-cells': > + const: 2 This is not a cooling device. BTW, your commit msg is somehow circular. "Add cooling to make it a cooling device because it will be then cooling device." Power supply already provides necessary framework for managing charging current and temperatures. If this is to stay, you need to explain why this is suitable to be considered a thermal zone or system cooling device (not power supply or input power cooling). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index aac8819bd00b..2b6f098057af 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -96,6 +96,9 @@ properties: '#gpio-cells': const: 2 + '#cooling-cells': + const: 2 + gpio-controller: true typec:
The cros_ec supports limiting the input current to act as a passive thermal cooling device. Add the property '#cooling-cells' bindings, such that thermal framework can recognize cros_ec as a valid thermal cooling device. Signed-off-by: Sung-Chi Li <lschyi@chromium.org> --- Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 3 +++ 1 file changed, 3 insertions(+)