diff mbox series

thermal/thresholds: Fix uapi header macros leading to a compilation error

Message ID 20241212201311.4143196-1-daniel.lezcano@linaro.org (mailing list archive)
State Queued
Delegated to: Rafael Wysocki
Headers show
Series thermal/thresholds: Fix uapi header macros leading to a compilation error | expand

Commit Message

Daniel Lezcano Dec. 12, 2024, 8:13 p.m. UTC
The macros giving the direction of the crossing thresholds use the BIT
macro which is not exported to the userspace. Consequently when an
userspace program includes the header, it fails to compile.

Replace the macros by their litteral to allow the compilation of
userspace program using this header.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 include/uapi/linux/thermal.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rafael J. Wysocki Dec. 16, 2024, 8:31 p.m. UTC | #1
On Thu, Dec 12, 2024 at 9:13 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> The macros giving the direction of the crossing thresholds use the BIT
> macro which is not exported to the userspace. Consequently when an
> userspace program includes the header, it fails to compile.
>
> Replace the macros by their litteral to allow the compilation of
> userspace program using this header.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  include/uapi/linux/thermal.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/thermal.h b/include/uapi/linux/thermal.h
> index ba8604bdf206..349718c271eb 100644
> --- a/include/uapi/linux/thermal.h
> +++ b/include/uapi/linux/thermal.h
> @@ -3,8 +3,8 @@
>  #define _UAPI_LINUX_THERMAL_H
>
>  #define THERMAL_NAME_LENGTH    20
> -#define THERMAL_THRESHOLD_WAY_UP       BIT(0)
> -#define THERMAL_THRESHOLD_WAY_DOWN     BIT(1)
> +#define THERMAL_THRESHOLD_WAY_UP       0x1
> +#define THERMAL_THRESHOLD_WAY_DOWN     0x2
>
>  enum thermal_device_mode {
>         THERMAL_DEVICE_DISABLED = 0,
> --

Applied as 6.13-rc material, thanks!
diff mbox series

Patch

diff --git a/include/uapi/linux/thermal.h b/include/uapi/linux/thermal.h
index ba8604bdf206..349718c271eb 100644
--- a/include/uapi/linux/thermal.h
+++ b/include/uapi/linux/thermal.h
@@ -3,8 +3,8 @@ 
 #define _UAPI_LINUX_THERMAL_H
 
 #define THERMAL_NAME_LENGTH	20
-#define THERMAL_THRESHOLD_WAY_UP	BIT(0)
-#define THERMAL_THRESHOLD_WAY_DOWN	BIT(1)
+#define THERMAL_THRESHOLD_WAY_UP	0x1
+#define THERMAL_THRESHOLD_WAY_DOWN	0x2
 
 enum thermal_device_mode {
 	THERMAL_DEVICE_DISABLED = 0,