| Message ID | 25039060.6131344561170907.JavaMail.weblogic@epml26 (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers | show |
On Friday, August 10, 2012, ??? wrote: > > + Myungjoo Ham, > > > > It used at devfreq. Mr. Ham can you explain it in detail? > > > > Thank you, > > Kyungmin Park > > , > > On 8/9/12, Rafael J. Wysocki <rjw@sisk.pl> wrote: > > > On Wednesday, August 08, 2012, Jonghwa Lee wrote: > > >> Bus throughput metric is added to PM QoS in order to control the > > >> frequency of memory interfaces and busses with PM QoS. > > >> > > >> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com> > > >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > > > > > I said some time ago I didn't want any new global PM QoS classes to be > > > added this way. > > > > > > Can you please post a driver patch using this new thing? > > > > > > Rafael > > It'd be too early for V4L2 device driver QoS patches as they are undergoing > major updates and the previous QoS patches over they are now obsolete. > > However, I've found that one QoS patch is still intact with the current one. > Here goes the example driver that uses Bus-Throughput for its operation. > (Fortunately, it is not V4L2, but DRM driver) > > It is a G2D (2D graphics acceleration) device driver that gets command lists > from userspace and then process them via DMA. Many command lists finish even > before any DVFS mechanism may react while the response time of a command list > is still important for the user processes. > > Here we go: Well, so my questions are: > --- > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > index d2d88f2..969b2c5 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > @@ -14,6 +14,7 @@ > #include <linux/interrupt.h> > #include <linux/io.h> > #include <linux/platform_device.h> > +#include <linux/pm_qos.h> > #include <linux/pm_runtime.h> > #include <linux/slab.h> > #include <linux/workqueue.h> > @@ -135,6 +136,7 @@ struct g2d_data { > struct workqueue_struct *g2d_workq; > struct work_struct runqueue_work; > struct exynos_drm_subdrv subdrv; > + struct pm_qos_request_list pm_qos; > bool suspended; > > /* cmdlist */ > @@ -314,6 +316,9 @@ static void g2d_dma_start(struct g2d_data *g2d, > pm_runtime_get_sync(g2d->dev); > clk_enable(g2d->gate_clk); > > + /* 416MHz w/ 64b 30% saturating bus */ > + pm_qos_update_request(&g2d->pm_qos, 1000000); > + (1) What's the unit of that number and (2) why is it global? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index d2d88f2..969b2c5 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c @@ -14,6 +14,7 @@ #include <linux/interrupt.h> #include <linux/io.h> #include <linux/platform_device.h> +#include <linux/pm_qos.h> #include <linux/pm_runtime.h> #include <linux/slab.h> #include <linux/workqueue.h> @@ -135,6 +136,7 @@ struct g2d_data { struct workqueue_struct *g2d_workq; struct work_struct runqueue_work; struct exynos_drm_subdrv subdrv; + struct pm_qos_request_list pm_qos; bool suspended; /* cmdlist */ @@ -314,6 +316,9 @@ static void g2d_dma_start(struct g2d_data *g2d, pm_runtime_get_sync(g2d->dev); clk_enable(g2d->gate_clk); + /* 416MHz w/ 64b 30% saturating bus */ + pm_qos_update_request(&g2d->pm_qos, 1000000); + /* interrupt enable */ writel_relaxed(G2D_INTEN_ACF | G2D_INTEN_UCF | G2D_INTEN_GCF, g2d->regs + G2D_INTEN); @@ -360,6 +365,7 @@ static void g2d_runqueue_worker(struct work_struct *work) struct g2d_data *g2d = container_of(work, struct g2d_data, runqueue_work); + pm_qos_update_request(&g2d->pm_qos, 0); mutex_lock(&g2d->runqueue_mutex); clk_disable(g2d->gate_clk); @@ -841,6 +847,8 @@ static int __devinit g2d_probe(struct platform_device *pdev) goto err_free_irq; } + pm_qos_add_request(&g2d->pm_qos, PM_QOS_BUS_DMA_THROUGHPUT, 0); + dev_info(dev, "The exynos g2d(ver %d.%d) successfully probed\n", G2D_HW_MAJOR_VER, G2D_HW_MINOR_VER); @@ -872,6 +880,7 @@ static int __devexit g2d_remove(struct platform_device *pdev) struct g2d_data *g2d = platform_get_drvdata(pdev); cancel_work_sync(&g2d->runqueue_work); + pm_qos_remove_request(&g2d->pm_qos); exynos_drm_subdrv_unregister(&g2d->subdrv); free_irq(g2d->irq, g2d);