| Message ID | 2787627.mvXUDI8C0e@rjwysocki.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] PM: sleep: Update stale comment in device_resume() | expand |
On Wed, Dec 04, 2024 at 02:02:04PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > There is no function called __device_suspend() any more and it is still > mentioned in a comment in device_resume(), so update that comment. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/base/power/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-pm/drivers/base/power/main.c > =================================================================== Are you not using git? This looks like the old cvs output :) Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On Wed, Dec 4, 2024 at 2:12 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Wed, Dec 04, 2024 at 02:02:04PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > There is no function called __device_suspend() any more and it is still > > mentioned in a comment in device_resume(), so update that comment. > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > --- > > drivers/base/power/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Index: linux-pm/drivers/base/power/main.c > > =================================================================== > > Are you not using git? This looks like the old cvs output :) I use git, but for patch generation I prefer quilt which has produced this patch. > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
On Wed, Dec 04, 2024 at 03:16:05PM +0100, Rafael J. Wysocki wrote: > On Wed, Dec 4, 2024 at 2:12 PM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > On Wed, Dec 04, 2024 at 02:02:04PM +0100, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > There is no function called __device_suspend() any more and it is still > > > mentioned in a comment in device_resume(), so update that comment. > > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > --- > > > drivers/base/power/main.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Index: linux-pm/drivers/base/power/main.c > > > =================================================================== > > > > Are you not using git? This looks like the old cvs output :) > > I use git, but for patch generation I prefer quilt which has produced > this patch. From my .quiltrc: QUILT_REFRESH_ARGS="--diffstat --strip-trailing-whitespace --no-timestamps --no-index --sort -p1 -p ab" makes it almost look like the git output :)
On Wed, Dec 4, 2024 at 3:20 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Wed, Dec 04, 2024 at 03:16:05PM +0100, Rafael J. Wysocki wrote: > > On Wed, Dec 4, 2024 at 2:12 PM Greg Kroah-Hartman > > <gregkh@linuxfoundation.org> wrote: > > > > > > On Wed, Dec 04, 2024 at 02:02:04PM +0100, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > There is no function called __device_suspend() any more and it is still > > > > mentioned in a comment in device_resume(), so update that comment. > > > > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > --- > > > > drivers/base/power/main.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > Index: linux-pm/drivers/base/power/main.c > > > > =================================================================== > > > > > > Are you not using git? This looks like the old cvs output :) > > > > I use git, but for patch generation I prefer quilt which has produced > > this patch. > > From my .quiltrc: > QUILT_REFRESH_ARGS="--diffstat --strip-trailing-whitespace --no-timestamps --no-index --sort -p1 -p ab" > > makes it almost look like the git output :) Good to know, thanks for the hint!
Index: linux-pm/drivers/base/power/main.c =================================================================== --- linux-pm.orig/drivers/base/power/main.c +++ linux-pm/drivers/base/power/main.c @@ -914,7 +914,7 @@ static void device_resume(struct device goto Complete; if (dev->power.direct_complete) { - /* Match the pm_runtime_disable() in __device_suspend(). */ + /* Match the pm_runtime_disable() in device_suspend(). */ pm_runtime_enable(dev); goto Complete; }