| Message ID | 317c55864546698b02c39b16b082812c2ac9400c.1641432983.git.edwinchiu0505tw@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | Add cpuidle driver for Sunplus SP7021 | expand |
On Thu, Jan 06, 2022 at 10:00:07AM +0800, Edwin Chiu wrote: > Add the compatible string for cpuidle state on sp7021 > > Signed-off-by: Edwin Chiu <edwinchiu0505tw@gmail.com> > --- > Changes in v3 > - Align email address of sob and sender > - Added sp7021 compatible string > > .../bindings/arm/sunplus/sunplus,idle-state.yaml | 59 ++++++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml > > diff --git a/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml b/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml > new file mode 100644 > index 0000000..64281ba > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. 2021 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/sunplus/sunplus,idle-state.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sunplus SOC cpuidle state > + > +maintainers: > + - Edwin Chiu<edwinchiu0505tw@gmail.com> > + > +description: | > + Sunplus SOC cpuidle state > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - sunplus,sp7021-idle-state > + > + entry-latency-us: > + description: > + Worst case latency in microseconds required to enter the idle state. > + > + exit-latency-us: > + description: > + Worst case latency in microseconds required to exit the idle state. > + The exit-latency-us duration may be guaranteed only after > + entry-latency-us has passed. > + > + min-residency-us: > + description: > + Minimum residency duration in microseconds, inclusive of preparation > + and entry, for this idle state to be considered worthwhile energy wise > + (refer to section 2 of this document for a complete description). > + > +required: > + - compatible > + - entry-latency-us > + - exit-latency-us > + - min-residency-us > + > +additionalProperties: true > + > +examples: > + - | > + > + idle-state { > + CPU_IDLE: cpu_idle { > + compatible = "sunplus,sp7021-idle-state"; > + entry-latency-us = <8000>; > + exit-latency-us = <700>; > + min-residency-us = <9000>; > + }; > + }; Again, this is no different than the generic binding. There is no need for this binding. Just wanting a different driver is not a reason for a duplicate schema. Rob
diff --git a/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml b/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml new file mode 100644 index 0000000..64281ba --- /dev/null +++ b/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) Sunplus Co., Ltd. 2021 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/sunplus/sunplus,idle-state.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sunplus SOC cpuidle state + +maintainers: + - Edwin Chiu<edwinchiu0505tw@gmail.com> + +description: | + Sunplus SOC cpuidle state + +properties: + compatible: + oneOf: + - items: + - enum: + - sunplus,sp7021-idle-state + + entry-latency-us: + description: + Worst case latency in microseconds required to enter the idle state. + + exit-latency-us: + description: + Worst case latency in microseconds required to exit the idle state. + The exit-latency-us duration may be guaranteed only after + entry-latency-us has passed. + + min-residency-us: + description: + Minimum residency duration in microseconds, inclusive of preparation + and entry, for this idle state to be considered worthwhile energy wise + (refer to section 2 of this document for a complete description). + +required: + - compatible + - entry-latency-us + - exit-latency-us + - min-residency-us + +additionalProperties: true + +examples: + - | + + idle-state { + CPU_IDLE: cpu_idle { + compatible = "sunplus,sp7021-idle-state"; + entry-latency-us = <8000>; + exit-latency-us = <700>; + min-residency-us = <9000>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index e0dca8f..22cfafe 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18252,6 +18252,11 @@ L: netdev@vger.kernel.org S: Maintained F: drivers/net/ethernet/dlink/sundance.c +SUNPLUS CPUIDLE DRIVER +M: Edwin Chiu <edwinchiu0505tw@gmail.com> +S: Maintained +F: Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml + SUPERH M: Yoshinori Sato <ysato@users.sourceforge.jp> M: Rich Felker <dalias@libc.org>
Add the compatible string for cpuidle state on sp7021 Signed-off-by: Edwin Chiu <edwinchiu0505tw@gmail.com> --- Changes in v3 - Align email address of sob and sender - Added sp7021 compatible string .../bindings/arm/sunplus/sunplus,idle-state.yaml | 59 ++++++++++++++++++++++ MAINTAINERS | 5 ++ 2 files changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml