| Message ID | 3b5b0e789b7296f7b38f4ab9503a53031280a672.1499831484.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On 07/12, Viresh Kumar wrote: > Some platforms add the OPPs dynamically from platform specific drivers > instead of getting them statically from DT. The cpufreq-dt driver > already ignores the return value of dev_pm_opp_of_cpumask_add_table() to > not error out for such cases, but we still end up printing error message > from that routine. That's not nice. > > Convert the print message to use pr_debug() instead. > > Reported-by: Mason <slash.tmp@free.fr> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
On Wednesday, July 12, 2017 11:10:14 PM Stephen Boyd wrote: > On 07/12, Viresh Kumar wrote: > > Some platforms add the OPPs dynamically from platform specific drivers > > instead of getting them statically from DT. The cpufreq-dt driver > > already ignores the return value of dev_pm_opp_of_cpumask_add_table() to > > not error out for such cases, but we still end up printing error message > > from that routine. That's not nice. > > > > Convert the print message to use pr_debug() instead. > > > > Reported-by: Mason <slash.tmp@free.fr> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > --- > > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> Applied, thanks!
diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c index 779428676f63..f1d8b01db546 100644 --- a/drivers/base/power/opp/of.c +++ b/drivers/base/power/opp/of.c @@ -533,8 +533,12 @@ int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask) ret = dev_pm_opp_of_add_table(cpu_dev); if (ret) { - pr_err("%s: couldn't find opp table for cpu:%d, %d\n", - __func__, cpu, ret); + /* + * OPP may get registered dynamically, don't print error + * message here. + */ + pr_debug("%s: couldn't find opp table for cpu:%d, %d\n", + __func__, cpu, ret); /* Free all other OPPs */ dev_pm_opp_of_cpumask_remove_table(cpumask);
Some platforms add the OPPs dynamically from platform specific drivers instead of getting them statically from DT. The cpufreq-dt driver already ignores the return value of dev_pm_opp_of_cpumask_add_table() to not error out for such cases, but we still end up printing error message from that routine. That's not nice. Convert the print message to use pr_debug() instead. Reported-by: Mason <slash.tmp@free.fr> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/base/power/opp/of.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)