From patchwork Tue Oct 23 04:22:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fengguang Wu X-Patchwork-Id: 1628681 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 949CE3FCF7 for ; Tue, 23 Oct 2012 04:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770Ab2JWEW3 (ORCPT ); Tue, 23 Oct 2012 00:22:29 -0400 Received: from mga01.intel.com ([192.55.52.88]:17484 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752724Ab2JWEW2 (ORCPT ); Tue, 23 Oct 2012 00:22:28 -0400 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 22 Oct 2012 21:22:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,633,1344236400"; d="diff'?scan'208";a="237054863" Received: from bee.sh.intel.com (HELO localhost) ([10.239.97.14]) by fmsmga001.fm.intel.com with ESMTP; 22 Oct 2012 21:22:26 -0700 Received: from [192.168.1.61] (helo=snb.lkp.intel.com) by localhost with smtp (Exim 4.80) (envelope-from ) id 1TQVyt-000CWD-NM; Tue, 23 Oct 2012 12:20:43 +0800 Date: Tue, 23 Oct 2012 12:22:11 +0800 From: Fengguang Wu To: "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org Subject: drivers/base/power/qos.c:330:5: sparse: symbol '__dev_pm_qos_update_request' was not declared. Should it be static? Message-ID: <50861b73.GgA1DPGYKvLmArF0%fengguang.wu@intel.com> User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.1.61 X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on localhost); SAEximRunCond expanded to false Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Rafael, FYI, there are new sparse warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next head: 13f5e2d9a915373dd1573d8fe0214738bc69004f commit: a7a02d1a295d3ab9cd894af4f138e30a3000df3d PM / QoS: Make it possible to expose PM QoS device flags to user space date: 5 hours ago + drivers/base/power/qos.c:330:5: sparse: symbol '__dev_pm_qos_update_request' was not declared. Should it be static? vim +330 drivers/base/power/qos.c ae0fb4b7 Rafael J. Wysocki 2012-10-23 314 req->type = type; b66213cd Jean Pihet 2011-08-25 315 ret = apply_constraint(req, PM_QOS_ADD_REQ, value); ae0fb4b7 Rafael J. Wysocki 2012-10-23 316 } 91ff4cb8 Jean Pihet 2011-08-25 317 1a9a9152 Rafael J. Wysocki 2011-09-29 318 out: 91ff4cb8 Jean Pihet 2011-08-25 319 mutex_unlock(&dev_pm_qos_mtx); 1a9a9152 Rafael J. Wysocki 2011-09-29 320 91ff4cb8 Jean Pihet 2011-08-25 321 return ret; 91ff4cb8 Jean Pihet 2011-08-25 322 } 91ff4cb8 Jean Pihet 2011-08-25 323 EXPORT_SYMBOL_GPL(dev_pm_qos_add_request); 91ff4cb8 Jean Pihet 2011-08-25 324 91ff4cb8 Jean Pihet 2011-08-25 325 /** a7a02d1a Rafael J. Wysocki 2012-10-23 326 * __dev_pm_qos_update_request - Modify an existing device PM QoS request. a7a02d1a Rafael J. Wysocki 2012-10-23 327 * @req : PM QoS request to modify. a7a02d1a Rafael J. Wysocki 2012-10-23 328 * @new_value: New value to request. a7a02d1a Rafael J. Wysocki 2012-10-23 329 */ a7a02d1a Rafael J. Wysocki 2012-10-23 @330 int __dev_pm_qos_update_request(struct dev_pm_qos_request *req, s32 new_value) a7a02d1a Rafael J. Wysocki 2012-10-23 331 { a7a02d1a Rafael J. Wysocki 2012-10-23 332 s32 curr_value; a7a02d1a Rafael J. Wysocki 2012-10-23 333 int ret = 0; a7a02d1a Rafael J. Wysocki 2012-10-23 334 a7a02d1a Rafael J. Wysocki 2012-10-23 335 if (!req->dev->power.qos) a7a02d1a Rafael J. Wysocki 2012-10-23 336 return -ENODEV; a7a02d1a Rafael J. Wysocki 2012-10-23 337 a7a02d1a Rafael J. Wysocki 2012-10-23 338 switch(req->type) { Please consider folding the attached diff :-) --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c index 3fcbf36..aba1218 100644 --- a/drivers/base/power/qos.c +++ b/drivers/base/power/qos.c @@ -327,7 +327,7 @@ EXPORT_SYMBOL_GPL(dev_pm_qos_add_request); * @req : PM QoS request to modify. * @new_value: New value to request. */ -int __dev_pm_qos_update_request(struct dev_pm_qos_request *req, s32 new_value) +static int __dev_pm_qos_update_request(struct dev_pm_qos_request *req, s32 new_value) { s32 curr_value; int ret = 0;