From patchwork Mon Feb 18 16:28:19 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lars-Peter Clausen X-Patchwork-Id: 2159511 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 8D44CDF25A for ; Mon, 18 Feb 2013 16:33:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086Ab3BRQdc (ORCPT ); Mon, 18 Feb 2013 11:33:32 -0500 Received: from smtp-out-078.synserver.de ([212.40.185.78]:1036 "EHLO smtp-out-078.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751502Ab3BRQdb (ORCPT ); Mon, 18 Feb 2013 11:33:31 -0500 X-Greylist: delayed 400 seconds by postgrey-1.27 at vger.kernel.org; Mon, 18 Feb 2013 11:33:31 EST Received: (qmail 19268 invoked by uid 0); 18 Feb 2013 16:26:49 -0000 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 19225 Received: from p4fe6350c.dip.t-dialin.net (HELO ?192.168.0.176?) [79.230.53.12] by 217.119.54.96 with AES256-SHA encrypted SMTP; 18 Feb 2013 16:26:48 -0000 Message-ID: <512256A3.6050100@metafoo.de> Date: Mon, 18 Feb 2013 17:28:19 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Len Brown CC: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown , uclinux-dist-devel@blackfin.uclinux.org Subject: Re: [PATCH 05/16] blackfin idle: delete pm_idle References: <1360475903-30007-1-git-send-email-lenb@kernel.org> <8408629d64626937a5202751703dae7f41941f7a.1360475150.git.len.brown@intel.com> In-Reply-To: <8408629d64626937a5202751703dae7f41941f7a.1360475150.git.len.brown@intel.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 02/10/2013 06:58 AM, Len Brown wrote: > From: Len Brown > > pm_idle is dead code on blackfin. > > Signed-off-by: Len Brown > Cc: uclinux-dist-devel@blackfin.uclinux.org > --- > arch/blackfin/kernel/process.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c > index 3e16ad9..8061426 100644 > --- a/arch/blackfin/kernel/process.c > +++ b/arch/blackfin/kernel/process.c > @@ -39,12 +39,6 @@ int nr_l1stack_tasks; > void *l1_stack_base; > unsigned long l1_stack_len; > > -/* > - * Powermanagement idle function, if any.. > - */ > -void (*pm_idle)(void) = NULL; > -EXPORT_SYMBOL(pm_idle); > - > void (*pm_power_off)(void) = NULL; > EXPORT_SYMBOL(pm_power_off); > > @@ -81,7 +75,6 @@ void cpu_idle(void) > { > /* endless idle loop with no priority at all */ > while (1) { > - void (*idle)(void) = pm_idle; Hi, This results in the following error: arch/blackfin/kernel/process.c: In function ‘cpu_idle’: arch/blackfin/kernel/process.c:83: error: ‘idle’ undeclared (first use in this function) arch/blackfin/kernel/process.c:83: error: (Each undeclared identifier is reported only once arch/blackfin/kernel/process.c:83: error: for each function it appears in.) arch/blackfin/kernel/process.c:88: error: implicit declaration of function ‘idle’ This change on top of your patch, fixes it. Otherwise the patch seems to work fine. - Lars --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c index 8061426..9782c03 100644 --- a/arch/blackfin/kernel/process.c +++ b/arch/blackfin/kernel/process.c @@ -80,12 +80,10 @@ void cpu_idle(void) if (cpu_is_offline(smp_processor_id())) cpu_die(); #endif - if (!idle) - idle = default_idle; tick_nohz_idle_enter(); rcu_idle_enter(); while (!need_resched()) - idle(); + default_idle(); rcu_idle_exit(); tick_nohz_idle_exit(); preempt_enable_no_resched();