From patchwork Tue Nov 17 01:57:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 7631861 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4FC92BF90C for ; Tue, 17 Nov 2015 01:57:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9544A2052A for ; Tue, 17 Nov 2015 01:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC50520528 for ; Tue, 17 Nov 2015 01:57:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751784AbbKQB5z (ORCPT ); Mon, 16 Nov 2015 20:57:55 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:36345 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbbKQB5y (ORCPT ); Mon, 16 Nov 2015 20:57:54 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NXX00BH2S4FV530@mailout4.w1.samsung.com>; Tue, 17 Nov 2015 01:57:51 +0000 (GMT) X-AuditID: cbfec7f5-f794b6d000001495-08-564a899f36fd Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 30.AA.05269.F998A465; Tue, 17 Nov 2015 01:57:51 +0000 (GMT) Received: from [0.0.0.0] ([106.116.37.23]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NXX003YWS4AYF70@eusync2.samsung.com>; Tue, 17 Nov 2015 01:57:51 +0000 (GMT) Subject: Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init To: Arnd Bergmann , "Rafael J. Wysocki" References: <8497197.sYxqVOch7s@wuerfel> <28389377.zxoR5rtJ13@vostro.rjw.lan> <4389196.cuM78vZZnJ@wuerfel> Cc: Kukjin Kim , Viresh Kumar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski Message-id: <564A899C.4040402@samsung.com> Date: Tue, 17 Nov 2015 10:57:48 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <4389196.cuM78vZZnJ@wuerfel> Content-type: multipart/mixed; boundary=------------080504020908010100070006 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t/xK7rzO73CDC795rf4O+kYu8XrF4YW /Y9fM1tsenyN1eLyrjlsFp97jzBazDi/j8nizOlLrBYbv3o4cHr8/jWJ0WPTqk42jzvX9rB5 bF5S77HlajuLR9+WVYwenzfJBbBHcdmkpOZklqUW6dslcGVMnXCWqeC6SsWPFZvYGhgnyncx cnJICJhIHLm0ggnCFpO4cG89WxcjF4eQwFJGiWcfzrNAOF8YJXaf/csCUiUs4CLR+fcJK4gt IuAlsXTCKXYQW0ggR2LepddgDcwC5xglzk5dygiSYBMwlti8fAnQWA4OXgEtiVdLE0DCLAKq Es9mvgbrFRWIkJg4oQFsJq+AoMSPyffAdnEKaEo0f1sPdh2zgI/E37YZLBMY+WchKZuFJAVh 60nsuP6LFcKWl9j+dg4zhG0i0dj1gx1T3FZi/8lG1gWM7KsYRVNLkwuKk9JzjfSKE3OLS/PS 9ZLzczcxQiLq6w7GpcesDjEKcDAq8fA2/PUME2JNLCuuzD3EqAI059GG1RcYpVjy8vNSlUR4 uSK8woR4UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUgtQgmy8TBKdXA2MLG asjZf/n3018MC9/Xqq+33Msnvrxr449zP4Mvrzllefb6p5Q7Tw+tYdm2+DHD/+Nss5SnBTxR sZ22I6JzynzLjPtZl47m7agvVo9JCVIPfrN065zigONBPl96Z7xZ+6zHgFs79qJRzrnHEr5C nitCn9a0r3tx0GHPFW6R/tnnJdkUX93QtVdiKc5INNRiLipOBADgKb2EsAIAAA== Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 17.11.2015 07:17, Arnd Bergmann wrote: > On Monday 16 November 2015 23:36:42 Rafael J. Wysocki wrote: >> >> This should go in through the Samsung tree, so I'll leave it for them to pick >> it up (at least for the time being). > > Ok, fair enough. Kukjin or Krzysztof, can you pick this up? Sure. As for the patch I think everything can be converted to init/initdata (as in attachment). Best regards, Krzysztof Reviewed-by: Krzysztof Kozlowski diff --git a/arch/arm/mach-s3c24xx/pll-s3c2410.c b/arch/arm/mach-s3c24xx/pll-s3c2410.c index 5e37d368594b..d9fd5319379b 100644 --- a/arch/arm/mach-s3c24xx/pll-s3c2410.c +++ b/arch/arm/mach-s3c24xx/pll-s3c2410.c @@ -65,12 +65,12 @@ static struct cpufreq_frequency_table pll_vals_12MHz[] = { { .frequency = 270000000, .driver_data = PLLVAL(127, 1, 1), }, }; -static int s3c2410_plls_add(struct device *dev, struct subsys_interface *sif) +static int __init s3c2410_plls_add(struct device *dev, struct subsys_interface *sif) { return s3c_plltab_register(pll_vals_12MHz, ARRAY_SIZE(pll_vals_12MHz)); } -static struct subsys_interface s3c2410_plls_interface = { +static struct subsys_interface s3c2410_plls_interface __initdata = { .name = "s3c2410_plls", .subsys = &s3c2410_subsys, .add_dev = s3c2410_plls_add, @@ -83,7 +83,7 @@ static int __init s3c2410_pll_init(void) } arch_initcall(s3c2410_pll_init); -static struct subsys_interface s3c2410a_plls_interface = { +static struct subsys_interface s3c2410a_plls_interface __initdata = { .name = "s3c2410a_plls", .subsys = &s3c2410a_subsys, .add_dev = s3c2410_plls_add, diff --git a/arch/arm/mach-s3c24xx/pll-s3c2440-12000000.c b/arch/arm/mach-s3c24xx/pll-s3c2440-12000000.c index a19460e6e7b0..01958230cf2f 100644 --- a/arch/arm/mach-s3c24xx/pll-s3c2440-12000000.c +++ b/arch/arm/mach-s3c24xx/pll-s3c2440-12000000.c @@ -50,7 +50,7 @@ static struct cpufreq_frequency_table s3c2440_plls_12[] __initdata = { { .frequency = 400000000, .driver_data = PLLVAL(0x5c, 1, 1), }, /* FVco 800.000000 */ }; -static int s3c2440_plls12_add(struct device *dev, struct subsys_interface *sif) +static int __init s3c2440_plls12_add(struct device *dev, struct subsys_interface *sif) { struct clk *xtal_clk; unsigned long xtal; @@ -71,7 +71,7 @@ static int s3c2440_plls12_add(struct device *dev, struct subsys_interface *sif) return 0; } -static struct subsys_interface s3c2440_plls12_interface = { +static struct subsys_interface s3c2440_plls12_interface __initdata = { .name = "s3c2440_plls12", .subsys = &s3c2440_subsys, .add_dev = s3c2440_plls12_add, @@ -84,7 +84,7 @@ static int __init s3c2440_pll_12mhz(void) } arch_initcall(s3c2440_pll_12mhz); -static struct subsys_interface s3c2442_plls12_interface = { +static struct subsys_interface s3c2442_plls12_interface __initdata = { .name = "s3c2442_plls12", .subsys = &s3c2442_subsys, .add_dev = s3c2440_plls12_add, diff --git a/arch/arm/mach-s3c24xx/pll-s3c2440-16934400.c b/arch/arm/mach-s3c24xx/pll-s3c2440-16934400.c index 1191b2905625..db9f476ab581 100644 --- a/arch/arm/mach-s3c24xx/pll-s3c2440-16934400.c +++ b/arch/arm/mach-s3c24xx/pll-s3c2440-16934400.c @@ -78,7 +78,7 @@ static struct cpufreq_frequency_table s3c2440_plls_169344[] __initdata = { { .frequency = 402192000, .driver_data = PLLVAL(87, 2, 1), }, /* FVco 804.384000 */ }; -static int s3c2440_plls169344_add(struct device *dev, +static int __init s3c2440_plls169344_add(struct device *dev, struct subsys_interface *sif) { struct clk *xtal_clk; @@ -100,7 +100,7 @@ static int s3c2440_plls169344_add(struct device *dev, return 0; } -static struct subsys_interface s3c2440_plls169344_interface = { +static struct subsys_interface s3c2440_plls169344_interface __initdata = { .name = "s3c2440_plls169344", .subsys = &s3c2440_subsys, .add_dev = s3c2440_plls169344_add, @@ -112,7 +112,7 @@ static int __init s3c2440_pll_16934400(void) } arch_initcall(s3c2440_pll_16934400); -static struct subsys_interface s3c2442_plls169344_interface = { +static struct subsys_interface s3c2442_plls169344_interface __initdata = { .name = "s3c2442_plls169344", .subsys = &s3c2442_subsys, .add_dev = s3c2440_plls169344_add,