From patchwork Mon Nov 2 11:27:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H. Nikolaus Schaller" X-Patchwork-Id: 7535741 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E45DE9F327 for ; Mon, 2 Nov 2015 11:28:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1333A20608 for ; Mon, 2 Nov 2015 11:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3724320585 for ; Mon, 2 Nov 2015 11:28:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753595AbbKBL1o (ORCPT ); Mon, 2 Nov 2015 06:27:44 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.160]:36196 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954AbbKBL1m (ORCPT ); Mon, 2 Nov 2015 06:27:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1446463660; l=1111; s=domk; d=goldelico.com; h=References:In-Reply-To:References:In-Reply-To:Date:Subject:Cc:To: From; bh=RxAhj0BgDvk/lhz2NM914u8Tf/qps2JQ4gguoCJvLdQ=; b=nmKyoM1jLjpvhtTLFPkAEYH+QNKaA7KdyL9lP2kpodDzIGgOqpbpO5x43mKWSU/rliN XWXf1zCi/iD4O+0WvagzofiQfHpowznKFgiLYwMpXXAOaBtq1U57L3+wqNpCBMMDBF/je I+0t09xfYxBVmXuwfGcnGpkq3aNn8QY3+jQ= X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mSAGQ+qKIDkoJ1Fv X-RZG-CLASS-ID: mo00 Received: from localhost.localdomain (p57AE0738.dip0.t-ipconnect.de [87.174.7.56]) by smtp.strato.de (RZmta 37.14 DYNA|AUTH) with ESMTPA id u02025rA2BRdG8Q; Mon, 2 Nov 2015 12:27:39 +0100 (CET) From: "H. Nikolaus Schaller" To: =?UTF-8?q?Gra=C5=BEvydas=20Ignotas?= , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Andreas Kemnade Cc: linux-pm@vger.kernel.org, gta04-owner@goldelico.com, linux-kernel@vger.kernel.org, "H. Nikolaus Schaller" Subject: [PATCH v2 3/3] drivers:power:twl4030-charger: don't check if battery is present Date: Mon, 2 Nov 2015 12:27:36 +0100 Message-Id: <79898642236850cd9d69d908a66ddcd778548eaf.1446463654.git.hns@goldelico.com> X-Mailer: git-send-email 2.5.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We can't assume that the battery is present after probing (it can sometimes be removed/hot swapped by the user while device (e.g. GTA04 or OpenPanodra) is operated through external AC or USB power). So it makes no sense to check for this situation (only) during probe. Signed-off-by: H. Nikolaus Schaller --- drivers/power/twl4030_charger.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c index 05d693d..6fbdf24 100644 --- a/drivers/power/twl4030_charger.c +++ b/drivers/power/twl4030_charger.c @@ -1006,13 +1006,6 @@ static int twl4030_bci_probe(struct platform_device *pdev) bci->irq_chg = platform_get_irq(pdev, 0); bci->irq_bci = platform_get_irq(pdev, 1); - /* Only proceed further *IF* battery is physically present */ - ret = twl4030_is_battery_present(bci); - if (ret) { - dev_crit(&pdev->dev, "Battery was not detected:%d\n", ret); - return ret; - } - platform_set_drvdata(pdev, bci); bci->ac = devm_power_supply_register(&pdev->dev, &twl4030_bci_ac_desc,