| Message ID | 8309e39737c480b0835454cbc6db345c5a27ecd4.1582871139.git.amit.kucheria@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | Cleanup dtbs_check warnings for tsens | expand |
On Fri, 28 Feb 2020 12:02:40 +0530, Amit Kucheria wrote: > The qcom-tsens binding requires a SoC-specific and a TSENS > family-specific binding to be specified in the compatible string. > > Since qcom,sc7180-tsens is not listed in the YAML binding, we see the > following warnings in 'make dtbs_check'. Fix them. > > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible: ['qcom,sc7180-tsens', > 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible > causes of the failure): > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:1: 'qcom,tsens-v0_1' was expected > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:1: 'qcom,tsens-v1' was expected > > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible: ['qcom,sc7180-tsens', > 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible > causes of the failure): > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:1: 'qcom,tsens-v0_1' was expected > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:1: 'qcom,tsens-v1' was expected > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > Reviewed-by: Vinod Koul <vkoul@kernel.org> > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
On 28/02/2020 07:32, Amit Kucheria wrote: [ ... ] > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index eef13b9446a8..13e294328932 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -39,6 +39,7 @@ properties: > - qcom,msm8996-tsens > - qcom,msm8998-tsens > - qcom,sdm845-tsens > + - qcom,sc7180-tsens This change is already done by https://patchwork.kernel.org/patch/11319259/ I've applied it.
On Tue, Mar 3, 2020 at 1:35 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > On 28/02/2020 07:32, Amit Kucheria wrote: > > [ ... ] > > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > index eef13b9446a8..13e294328932 100644 > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > > @@ -39,6 +39,7 @@ properties: > > - qcom,msm8996-tsens > > - qcom,msm8998-tsens > > - qcom,sdm845-tsens > > + - qcom,sc7180-tsens > > This change is already done by > > https://patchwork.kernel.org/patch/11319259/ > > I've applied it. Good catch! I'd forgotten I'd even reviewed it when I saw all these warnings with dtbs_check :-)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index eef13b9446a8..13e294328932 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -39,6 +39,7 @@ properties: - qcom,msm8996-tsens - qcom,msm8998-tsens - qcom,sdm845-tsens + - qcom,sc7180-tsens - const: qcom,tsens-v2 reg: