| Message ID | 8468bdbea87003dc05bd10d15b51e6d27f306a20.1693218539.git.zhoubinbin@loongson.cn (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | soc: loongson: Fix some issues about loongson_pm2 | expand |
On Mon, Aug 28, 2023 at 08:38:33PM +0800, Binbin Zhou wrote: > Add compatible for Loongson-2K2000, which also has the Loongson2 > Power Management Unit system controller. > > This is a missing compatible, now we add it. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > drivers/soc/loongson/loongson2_pm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/loongson/loongson2_pm.c b/drivers/soc/loongson/loongson2_pm.c > index 796add6e8b63..6d2b3708e947 100644 > --- a/drivers/soc/loongson/loongson2_pm.c > +++ b/drivers/soc/loongson/loongson2_pm.c > @@ -198,6 +198,7 @@ static int loongson2_pm_probe(struct platform_device *pdev) > static const struct of_device_id loongson2_pm_match[] = { > { .compatible = "loongson,ls2k0500-pmc", }, > { .compatible = "loongson,ls2k1000-pmc", }, > + { .compatible = "loongson,ls2k2000-pmc", }, You've not added any new codepaths for this soc, so it is compatible with the existing ones. Why are you not using fallback compatibles for this?
On 28/08/2023 14:38, Binbin Zhou wrote: > Add compatible for Loongson-2K2000, which also has the Loongson2 > Power Management Unit system controller. > > This is a missing compatible, now we add it. How is it missing? Was support for it added before but not complete? Best regards, Krzysztof
diff --git a/drivers/soc/loongson/loongson2_pm.c b/drivers/soc/loongson/loongson2_pm.c index 796add6e8b63..6d2b3708e947 100644 --- a/drivers/soc/loongson/loongson2_pm.c +++ b/drivers/soc/loongson/loongson2_pm.c @@ -198,6 +198,7 @@ static int loongson2_pm_probe(struct platform_device *pdev) static const struct of_device_id loongson2_pm_match[] = { { .compatible = "loongson,ls2k0500-pmc", }, { .compatible = "loongson,ls2k1000-pmc", }, + { .compatible = "loongson,ls2k2000-pmc", }, {}, };
Add compatible for Loongson-2K2000, which also has the Loongson2 Power Management Unit system controller. This is a missing compatible, now we add it. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> --- drivers/soc/loongson/loongson2_pm.c | 1 + 1 file changed, 1 insertion(+)