From patchwork Fri Jun 30 17:55:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 9820217 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 61CA1603D7 for ; Fri, 30 Jun 2017 17:55:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5127F2868D for ; Fri, 30 Jun 2017 17:55:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 45742286B6; Fri, 30 Jun 2017 17:55:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C991F2868D for ; Fri, 30 Jun 2017 17:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751940AbdF3Rzd (ORCPT ); Fri, 30 Jun 2017 13:55:33 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:35292 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbdF3Rzc (ORCPT ); Fri, 30 Jun 2017 13:55:32 -0400 Received: by mail-qk0-f172.google.com with SMTP id 16so107065566qkg.2; Fri, 30 Jun 2017 10:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Yn8Q40+0roJ3N1RFqh/44ctZmTVV5pQTn7nzaPDvdP0=; b=FvUf0WV2T0N9ho9TwmvrbB9IybXvMXpyPTlFpKY0X22GxhhGiRorVs4atXyC/vqhnU N7ZU0IJjnimi4W36fEI4qjdc8fLfSHONBOMw+k0fIDDiWcq6lEsOHbUu5VgeTDHve6oU 14vHytF6b0v3U8tggZ2oaQSw/Gfa6WrFmD9Z55BNB3pa0X5oj+Hp0yQqBnvcWkSjBH/l Js6MXzBJCetYLveOplmhONVD3FGabs9Eb+l5Q+8ugwn2X5kGDI/QfEATnsg+UrUlDIhq XTtatrCHAZ3xwLKmsqJJYB1h+BmUt4WCO2uOeAQQGf7hJSX25BJmwpDSPoIBiKwH+WOr /THA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Yn8Q40+0roJ3N1RFqh/44ctZmTVV5pQTn7nzaPDvdP0=; b=R3YIti7QQ/fG/8atAFWENqL/Vdpo14P6G4N0g9HKuGOLRGH/9ExKsT8IVAcyP1Vmwm kQTtjh+6gBk60W4RxLIBUgXjaYsX4xu5EWIEcU7/SFI2GBhjqiXQPQZmimD6I2JN91er zqHXwaAPkDv77gpclnMJMQyZIpu3TR2EFIa15kJKvKppNoYJW/3C+PkA8dbtUb6fyMvD TNheMJ3QMSYdNzi7G5Yw38/clf/j1mHxsivYyDUIh9KACkmv3hg7YZ8erItTeJcDu6oQ 0ymcgw9jUKW6Jm1O25PVJSfcUi0ePPNA9YHHVFSkUrsGutk2RD0G7RUHN0mbQ1joJ9qz 80lA== X-Gm-Message-State: AKS2vOyls7yEYOh4AQjGbVM0lbCmC07tUw3RqdkYilzvSyorOMRRVFJR 5TYYZiJ4cssfE+JG7TMBWRCykBtETA== X-Received: by 10.55.204.133 with SMTP id n5mr27939269qkl.135.1498845331831; Fri, 30 Jun 2017 10:55:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.135.137 with HTTP; Fri, 30 Jun 2017 10:55:30 -0700 (PDT) In-Reply-To: References: <20170629121009.30234-1-benjamin.tissoires@redhat.com> <20170630155706.GL26073@mail.corp.redhat.com> <7d8201bf-b05e-6235-7eb0-54b1a393f99f@redhat.com> From: Andy Shevchenko Date: Fri, 30 Jun 2017 20:55:30 +0300 Message-ID: Subject: Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation To: Hans de Goede Cc: Benjamin Tissoires , Bastien Nocera , Stephen Just , Sebastian Reichel , "Rafael J . Wysocki" , Len Brown , Robert Moore , Lv Zheng , Mika Westerberg , "linux-acpi@vger.kernel.org" , devel@acpica.org, "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Jun 30, 2017 at 8:42 PM, Hans de Goede wrote: > On 30-06-17 19:40, Andy Shevchenko wrote: >> On Fri, Jun 30, 2017 at 8:37 PM, Hans de Goede >> wrote: >>> On 30-06-17 18:37, Andy Shevchenko wrote: >>>> On Fri, Jun 30, 2017 at 6:57 PM, Benjamin Tissoires > Care to share that? Between me and Benjamin one of us can hopefully > find the time to test / finish it (should be trivial really). Not tested at all. From ea8aa2823410393bbf67a1182339aea439d8f81d Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Fri, 30 Jun 2017 20:53:00 +0300 Subject: [PATCH 1/1] i2c: core: Allow empty id_table in ACPI case as well For now empty ID table is not allowed with ACPI and prevents driver to be probed. Add a check to allow empty ID table. Signed-off-by: Andy Shevchenko --- drivers/i2c/i2c-core-base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index c89dac7fd2e7..45231d2257ad 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -354,9 +354,10 @@ static int i2c_device_probe(struct device *dev) /* * An I2C ID table is not mandatory, if and only if, a suitable Device - * Tree match table entry is supplied for the probing device. + * Tree or ACPI match table entry is supplied for the probing device. */ if (!driver->id_table && + !acpi_match_device(dev->driver->acpi_match_table, &client->dev) && !i2c_of_match_device(dev->driver->of_match_table, client)) return -ENODEV; -- 2.11.0