From patchwork Tue Feb 18 13:07:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 3670251 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 029DC9F39B for ; Tue, 18 Feb 2014 13:07:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4EDD6201D3 for ; Tue, 18 Feb 2014 13:07:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64F7D201BA for ; Tue, 18 Feb 2014 13:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755321AbaBRNHS (ORCPT ); Tue, 18 Feb 2014 08:07:18 -0500 Received: from mail-ve0-f170.google.com ([209.85.128.170]:33979 "EHLO mail-ve0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755256AbaBRNHR (ORCPT ); Tue, 18 Feb 2014 08:07:17 -0500 Received: by mail-ve0-f170.google.com with SMTP id cz12so13759196veb.1 for ; Tue, 18 Feb 2014 05:07:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=XLiJZc1x3d6byH1Fk3H0bxCvkhuWlmEHJb01o03qZs8=; b=L7Bk5DfVWD0gnHPewLi9SBnwv2R5fINLwl1rZRhTofrsPuVjoVW5chBxGFG5hrOJED yfjOJ3/tdvJZfRCADc9yJO/tUbrR5grZq98eN3p2PuHko5waxWZE/lUphQ4xMpLoqphK M9T/80K8RWuohd1H6SVZuQ3zoN4LrOTVgM0ESwHvxV/DqKfWZvrKWYPlk19Qhobgthg+ UWrqFsoh8yQVnKHDQ59lvoXfCe+Aj1x3+U0fUhh4lTRxIVelYZxBjkuYWVF6Ot2carlx nZCyYv++XwgO1NptJGq3ahrO6ULkzWa+tKYSWWzYEaLpYZol/Jw1p2qNFrYgm8GcrUp1 rGjg== MIME-Version: 1.0 X-Received: by 10.52.22.105 with SMTP id c9mr573694vdf.57.1392728836149; Tue, 18 Feb 2014 05:07:16 -0800 (PST) Received: by 10.58.19.100 with HTTP; Tue, 18 Feb 2014 05:07:16 -0800 (PST) In-Reply-To: <1490688.YGyTpvjYUy@vostro.rjw.lan> References: <1392726951-8256-1-git-send-email-fabio.estevam@freescale.com> <1490688.YGyTpvjYUy@vostro.rjw.lan> Date: Tue, 18 Feb 2014 10:07:16 -0300 Message-ID: Subject: Re: [PATCH v2] cpufreq: Kconfig.arm: Fix unmet direct dependencies From: Fabio Estevam To: "Rafael J. Wysocki" Cc: Fabio Estevam , Viresh Kumar , Shawn Guo , Mark Langsdorf , "linux-pm@vger.kernel.org" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Feb 18, 2014 at 9:57 AM, Rafael J. Wysocki wrote: > On Tuesday, February 18, 2014 09:35:51 AM Fabio Estevam wrote: >> Currently the following warning is generated when building multi_v7_defconfig: >> >> $ make multi_v7_defconfig >> warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL) >> # configuration written to .config >> >> Instead of forcing the selection of GENERIC_CPUFREQ_CPU0 and REGULATOR, change >> it to 'depends on' instead. > > OK > > Any objections here? Thinking more about it I think the correct fix would be: Because we have: config GENERIC_CPUFREQ_CPU0 tristate "Generic CPU0 cpufreq driver" depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL select PM_OPP help This adds a generic cpufreq driver for CPU0 frequency management. It supports both uniprocessor (UP) and symmetric multiprocessor (SMP) systems which share clock and voltage across all CPUs. If everyone agrees I would send a v3 with such fix. Thanks, Fabio Estevam --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -84,9 +84,7 @@ config ARM_EXYNOS_CPU_FREQ_BOOST_SW config ARM_HIGHBANK_CPUFREQ tristate "Calxeda Highbank-based" depends on ARCH_HIGHBANK - select GENERIC_CPUFREQ_CPU0 - select PM_OPP - select REGULATOR + depends on GENERIC_CPUFREQ_CPU0 default m help