| Message ID | E1YW7sl-0003m2-4Z@rmk-PC.arm.linux.org.uk (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers | show |
On 12 March 2015 at 19:30, Russell King <rmk+kernel@arm.linux.org.uk> wrote: > PM domains are rather noisy; scheduling behaviour can cause callbacks > to take longer, which causes them to spit out a warning-level message > each time a callback takes a little longer than the previous time. > There really isn't a need for this, except when debugging. > > Acked-by: Rafael J. Wysocki <rjw@rjwysocki.net> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Acked-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/base/power/domain.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 0d8780c04a5e..b3fbc21da2dc 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -173,8 +173,8 @@ static int genpd_power_on(struct generic_pm_domain *genpd) > genpd->power_on_latency_ns = elapsed_ns; > genpd->max_off_time_changed = true; > genpd_recalc_cpu_exit_latency(genpd); > - pr_warn("%s: Power-%s latency exceeded, new value %lld ns\n", > - genpd->name, "on", elapsed_ns); > + pr_debug("%s: Power-%s latency exceeded, new value %lld ns\n", > + genpd->name, "on", elapsed_ns); > > return ret; > } > @@ -199,8 +199,8 @@ static int genpd_power_off(struct generic_pm_domain *genpd) > > genpd->power_off_latency_ns = elapsed_ns; > genpd->max_off_time_changed = true; > - pr_warn("%s: Power-%s latency exceeded, new value %lld ns\n", > - genpd->name, "off", elapsed_ns); > + pr_debug("%s: Power-%s latency exceeded, new value %lld ns\n", > + genpd->name, "off", elapsed_ns); > > return ret; > } > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Russell King <rmk+kernel@arm.linux.org.uk> writes: > PM domains are rather noisy; scheduling behaviour can cause callbacks > to take longer, which causes them to spit out a warning-level message > each time a callback takes a little longer than the previous time. > There really isn't a need for this, except when debugging. > > Acked-by: Rafael J. Wysocki <rjw@rjwysocki.net> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Acked-by: Kevin Hilman <khilman@linaro.org> We also take several timings even for callbacks that don't exist, and I've got a forthcoming patch to clean that up as well. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 0d8780c04a5e..b3fbc21da2dc 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -173,8 +173,8 @@ static int genpd_power_on(struct generic_pm_domain *genpd) genpd->power_on_latency_ns = elapsed_ns; genpd->max_off_time_changed = true; genpd_recalc_cpu_exit_latency(genpd); - pr_warn("%s: Power-%s latency exceeded, new value %lld ns\n", - genpd->name, "on", elapsed_ns); + pr_debug("%s: Power-%s latency exceeded, new value %lld ns\n", + genpd->name, "on", elapsed_ns); return ret; } @@ -199,8 +199,8 @@ static int genpd_power_off(struct generic_pm_domain *genpd) genpd->power_off_latency_ns = elapsed_ns; genpd->max_off_time_changed = true; - pr_warn("%s: Power-%s latency exceeded, new value %lld ns\n", - genpd->name, "off", elapsed_ns); + pr_debug("%s: Power-%s latency exceeded, new value %lld ns\n", + genpd->name, "off", elapsed_ns); return ret; }