From patchwork Mon Feb 14 20:55:38 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Alan Stern <stern@rowland.harvard.edu>
X-Patchwork-Id: 557271
Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org
	[140.211.169.13])
	by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1ENCXXf028558
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL)
	for <patchwork-linux-pm@patchwork.kernel.org>;
	Mon, 14 Feb 2011 23:12:54 GMT
Received: from daredevil.linux-foundation.org (localhost [127.0.0.1])
	by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with
	ESMTP id p1EN9pbm000937; Mon, 14 Feb 2011 15:09:51 -0800
Received: from iolanthe.rowland.org (iolanthe.rowland.org [192.131.102.54])
	by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1)
	with
	SMTP id p1EL2Kue028708 for <linux-pm@lists.linux-foundation.org>;
	Mon, 14 Feb 2011 13:02:21 -0800
Received: (qmail 4344 invoked by uid 2102); 14 Feb 2011 15:55:38 -0500
Received: from localhost (sendmail-bs@127.0.0.1)
	by localhost with SMTP; 14 Feb 2011 15:55:38 -0500
Date: Mon, 14 Feb 2011 15:55:38 -0500 (EST)
From: Alan Stern <stern@rowland.harvard.edu>
X-X-Sender: stern@iolanthe.rowland.org
To: Dirk Hohndel <hohndel@infradead.org>
In-Reply-To: <m31v3abf1k.fsf@x201s.gr8dns.org>
Message-ID: <Pine.LNX.4.44L0.1102141541120.1716-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Received-SPF: pass (localhost is always allowed.)
X-Spam-Status: No, hits=-3.993 required=5 tests=AWL, BAYES_00,
	OSDL_HEADER_SUBJECT_BRACKETED
X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__
X-MIMEDefang-Filter: lf$Revision: 1.188 $
X-Scanned-By: MIMEDefang 2.63 on 140.211.169.21
Cc: Linux PM List <linux-pm@lists.linux-foundation.org>,
	Linux USB List <linux-usb@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [linux-pm] USB suspend issue with 2.6.38-rc2 -- still there in
	RC4-g795abaf
X-BeenThere: linux-pm@lists.linux-foundation.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Linux power management <linux-pm.lists.linux-foundation.org>
List-Unsubscribe: 
 <https://lists.linux-foundation.org/mailman/listinfo/linux-pm>,
	<mailto:linux-pm-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linux-foundation.org/pipermail/linux-pm>
List-Post: <mailto:linux-pm@lists.linux-foundation.org>
List-Help: <mailto:linux-pm-request@lists.linux-foundation.org?subject=help>
List-Subscribe: 
 <https://lists.linux-foundation.org/mailman/listinfo/linux-pm>,
	<mailto:linux-pm-request@lists.linux-foundation.org?subject=subscribe>
Sender: linux-pm-bounces@lists.linux-foundation.org
Errors-To: linux-pm-bounces@lists.linux-foundation.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]);
	Mon, 14 Feb 2011 23:12:54 +0000 (UTC)


Index: usb-2.6/drivers/usb/core/hub.c
===================================================================
--- usb-2.6.orig/drivers/usb/core/hub.c
+++ usb-2.6/drivers/usb/core/hub.c
@@ -2457,21 +2457,6 @@ int usb_port_resume(struct usb_device *u
 static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
 {
 	struct usb_hub		*hub = usb_get_intfdata (intf);
-	struct usb_device	*hdev = hub->hdev;
-	unsigned		port1;
-
-	/* fail if children aren't already suspended */
-	for (port1 = 1; port1 <= hdev->maxchild; port1++) {
-		struct usb_device	*udev;
-
-		udev = hdev->children [port1-1];
-		if (udev && udev->can_submit) {
-			if (!(msg.event & PM_EVENT_AUTO))
-				dev_dbg(&intf->dev, "port %d nyet suspended\n",
-						port1);
-			return -EBUSY;
-		}
-	}
 
 	dev_dbg(&intf->dev, "%s\n", __func__);