diff mbox

PM / OPP: fix odd_ptr_err.cocci warnings

Message ID alpine.DEB.2.10.1612021611340.3056@hadrien (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Julia Lawall Dec. 2, 2016, 3:13 p.m. UTC 
PTR_ERR should access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

I haven't checked the context, but the code looks suspicious.

This is derived from the following tree:

tree:   https://git.linaro.org/people/vireshk/linux opp/redesign
head:   fbf8f0c337a7cfcd4cb67865b5ea710e69c21f1f
commit: 5fe43a6b46470d22938bc443cf0ea20ed01a93b6 [32/33] PM / OPP: Take
kref from _find_opp_table()
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Viresh Kumar Dec. 5, 2016, 3:14 a.m. UTC | #1 
On 02-12-16, 16:13, Julia Lawall wrote:
>  PTR_ERR should access the value just tested by IS_ERR
> 
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> 
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
> I haven't checked the context, but the code looks suspicious.
> 
> This is derived from the following tree:
> 
> tree:   https://git.linaro.org/people/vireshk/linux opp/redesign
> head:   fbf8f0c337a7cfcd4cb67865b5ea710e69c21f1f
> commit: 5fe43a6b46470d22938bc443cf0ea20ed01a93b6 [32/33] PM / OPP: Take
> kref from _find_opp_table()
> :::::: branch date: 4 hours ago
> :::::: commit date: 4 hours ago
> 
>  core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/base/power/opp/core.c
> +++ b/drivers/base/power/opp/core.c
> @@ -644,7 +644,7 @@ int dev_pm_opp_set_rate(struct device *d
>  	if (IS_ERR(clk)) {
>  		dev_err(dev, "%s: No clock available for the device\n",
>  			__func__);
> -		ret = PTR_ERR(opp_table);
> +		ret = PTR_ERR(clk);
>  		goto put_opp_table;
>  	}

Fixed, thanks.
diff mbox

Patch

--- a/drivers/base/power/opp/core.c
+++ b/drivers/base/power/opp/core.c
@@ -644,7 +644,7 @@  int dev_pm_opp_set_rate(struct device *d
 	if (IS_ERR(clk)) {
 		dev_err(dev, "%s: No clock available for the device\n",
 			__func__);
-		ret = PTR_ERR(opp_table);
+		ret = PTR_ERR(clk);
 		goto put_opp_table;
 	}